feat(nakama): add reincarnation placeholder#16
Merged
Conversation
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
8ca5b9c to
16f5fbe
Compare
e1b41c9 to
5a4e22c
Compare
Contributor
Author
|
Local delta review after rebase onto current dev:
Verification:
Verdict: APPROVED for merge into dev if CI remains green. |
Contributor
Author
|
Local delta review after rebase onto dev:
Verification:
Verdict: APPROVED for merge into dev. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
secondspawn_reincarnateas the prototype death to fresh-body flow after BodyTime reaches zero.Verification
npm run buildinbackend/nakamanpm testinbackend/nakamago test -count=1 ./...inbackend/gatewaygo vet ./...inbackend/gatewaynpx --yes markdownlint-cli2@0.18.1 "*.md" "docs/**/*.md" ".github/**/*.md"git diff --checkLocal Review
Local
code-reviewskill pass result: approved with suggestions. No engine specialist is configured in.Codex/docs/technical-preferences.md, so specialist routing was skipped. This keeps the placeholder in Nakama runtime per ADR 0010 and keeps SECOND distinct from current-body BodyTime.Caveat
Unity clean-worktree batchmode compile is still blocked by the existing Package Manager
pathundefined issue in this repo family, so Editor/MCP compile verification remains required before a no-caveat Unity merge claim.Gemini (@gemini-code-assist) review
Codex (@codex) review