fix #5546: remove incorrect for attribute from label in array form fi…

[guillermo-escire]

References

Fixes #5546

Description

Removes the incorrect for attribute from labels associated with array-type form fields in the submission form, replacing it with aria-labelledby on the array container to maintain accessibility without triggering browser warnings.

Instructions for Reviewers

List of changes in this PR:

• In ds-dynamic-form-control-container.component.html, changed the label's [for] binding to use [attr.for] with a conditional that sets it to null when the model type is ARRAY, preventing the browser accessibility warning.
• In dynamic-form-array.component.html, added [attr.aria-labelledby] to the array container div, pointing to the label's id, maintaining proper accessibility.
• Added a test in ds-dynamic-form-control-container.component.spec.ts to verify the label has no for attribute when the model type is ARRAY.
• Added a test in dynamic-form-array.component.spec.ts to verify the array container has the correct aria-labelledby attribute.

How to test:

1. Open the submission form at /workspaceitems/{id}/edit
2. Open DevTools (F12) and go to the Console tab
3. Filter by Incorrect use — the warning should no longer appear
4. Inspect the "Other Titles" field — the should have no for attribute and the array
   should have aria-labelledby pointing to the label's id

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

• My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
• My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
• My PR passes ESLint validation using npm run lint
• My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
• My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
• My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
• My PR aligns with Accessibility guidelines if it makes changes to the user interface.
• My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
• My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
• If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
• If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
• If my PR fixes an issue ticket, I've linked them together.

[lgeggleston]

Confirmed that this fixes the original mismatched label issue, and no regressions on the non-array form fields!

However, there is now an issue on the <label> element for array fields saying "No label associated with a form field", which makes sense when removing the for attribute for those. Since you're now associating it with the container rather than individual inputs, is it possible to keep the for attr but associate it with the container ID for arrays?

[guillermo-escire]

Hi @lgeggleston, Thank you for the review!

You're right that removing the for attribute introduces the "No label associated with a form field" warning.
Regarding your suggestion of keeping for pointing to the container ID, technically, the HTML spec requires for to reference an interactive form control (input, select, textarea), not a div, which is why the original warning appeared in the first place. Pointing for to the array container div would resolve the new warning but would still not be fully spec-compliant.

Would you prefer we keep for pointing to the container div as a pragmatic solution, or would you like us to explore another approach such as wrapping the array, which is the semantically correct way to associate a label with a group of controls?

[github-actions]

Hi @guillermo-escire,
Conflicts have been detected against the base branch.
Please resolve these conflicts as soon as you can. Thanks!