Skip to content

Minor update that fixes the back button for communities - #5982

Open
mspalti wants to merge 1 commit into
DSpace:mainfrom
mspalti:back-button-update
Open

Minor update that fixes the back button for communities#5982
mspalti wants to merge 1 commit into
DSpace:mainfrom
mspalti:back-button-update

Conversation

@mspalti

@mspalti mspalti commented Jul 21, 2026

Copy link
Copy Markdown
Member

Description

When the search option was created for communities that added a new path from which result lists originate. I believe that change happened in DSpace 8? I didn't upgrade our site to 8, so my guess is that a back link to community search results just didn't appear item pages.

It looks like there's a different issue after the improvements to back button logic in #5170. You can see the problem by navigating to a collection search page and selecting an item. The back button will return you to the collection page search result. Then navigate to a community search page and select an item. The back button will return you to the previously viewed collection search result list since that was the last route to be cached. You see the same thing when the home page is the last route in the cache.

It looks like we just need to add "communities" to the regex for previous routes so it will be used and properly cached.

Instructions for Reviewers

List of changes in this PR:

  • Updated the "previousRoute" regex to include "communities"

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@lgeggleston lgeggleston added bug usability 1 APPROVAL pull request only requires a single approval to merge component: Community Community display or editing port to dspace-9_x This PR needs to be ported to `dspace-9_x` branch for next bug-fix release port to dspace-10_x This PR needs to be ported to `dspace-10_x` branch for next bug-fix release labels Jul 22, 2026
@lgeggleston lgeggleston moved this to 🙋 Needs Reviewers Assigned in DSpace 11.0 Release Jul 22, 2026
@lgeggleston

Copy link
Copy Markdown
Contributor

Thank you for contributing this fix @mspalti! Adding to a project board for reviewers to take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge bug component: Community Community display or editing port to dspace-9_x This PR needs to be ported to `dspace-9_x` branch for next bug-fix release port to dspace-10_x This PR needs to be ported to `dspace-10_x` branch for next bug-fix release usability

Projects

Status: 🙋 Needs Reviewers Assigned

Development

Successfully merging this pull request may close these issues.

2 participants