Skip to content

Hide duplicate back/cancel button on the collection mapper page - #5988

Open
alexandrevryghem wants to merge 2 commits into
DSpace:mainfrom
alexandrevryghem:fix-hide-return-button-for-edit-dso-pages_contribute-main
Open

Hide duplicate back/cancel button on the collection mapper page#5988
alexandrevryghem wants to merge 2 commits into
DSpace:mainfrom
alexandrevryghem:fix-hide-return-button-for-edit-dso-pages_contribute-main

Conversation

@alexandrevryghem

@alexandrevryghem alexandrevryghem commented Jul 24, 2026

Copy link
Copy Markdown
Member

Description

Hide the Back button on the collection mapper, similar to the item mapper page. Also aligned the buttons in the same way and added icons to the item mapper buttons.

image

Instructions for Reviewers

List of changes in this PR:

  • Aligned the cancel & save/discard buttons
  • Added the same Font Awesome icons from the item mapper to the collection mapper
  • Made it possible to hide the Back button on edit item pages
  • Updated the hide Back button logic on comcol pages to also work for specific nested child routes. Previously this was only configurable for direct edit bitstream routes. So for example now you can hide the back button for the /collections/{uuid}/edit/authorizations/create route without automatically having to hide it for the /collections/{uuid}/edit/authorizations route
  • Also updated the default edit item page to have a default margin bottom on the group of tabs similar to the comcol pages

Guidance for how to test or review this PR:

  • Verify the collection mapper in the edit item view doesn't display the Back button

Checklist

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

Also used margin bottom on the EditItemPageComponent tabs to allign the spacing with the comcol pages
@alexandrevryghem alexandrevryghem self-assigned this Jul 24, 2026
@alexandrevryghem alexandrevryghem added quick win Pull request is small in size & should be easy to review and/or merge ux User Experience related works labels Jul 24, 2026
@alexandrevryghem alexandrevryghem moved this to 🙋 Needs Reviewers Assigned in DSpace 11.0 Release Jul 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

quick win Pull request is small in size & should be easy to review and/or merge ux User Experience related works

Projects

Status: 🙋 Needs Reviewers Assigned

Development

Successfully merging this pull request may close these issues.

1 participant