Fsd cosmic sim#220
Open
diaza wants to merge 17 commits into
Open
Conversation
Remove the waveform deconvolution step for now as the FSD specific inputs are not available. Fix a typo in the channel map in `LightEventGeneratorMC.yaml` Change a few remaining 2x2 values to FSD values (e.g. nchantpc)
Addresses build issues with recent versions of numpy and cython
Original channel map modified based on examining event displays to achieve something that visually looked okay. This may be incorrect and need further tweaks, or there is some other place that needs to be corrected to use the original uploaded map. Additional corrections to FSD light yamls.
Accepted code/changes in develop for merge conflicts.
Fsd geometry fix
Contributor
|
Yes, we should. This was previously held up by some merge conflicts the last time I looked at it. I pulled develop into fsd_cosmic_sim, and had not got around to going back the other way since I am a little afraid of somehow overwriting some configs with old values given the previous conflicts. |
Correct FSD op channel mapping
Add the updated gain and voltages based on data conditions for the FSD in CalibHitBuilderMC.yaml
cuddandr
force-pushed
the
fsd_cosmic_sim
branch
from
e36fb6d to
fe45b8f
Compare
Most changes were copying in the new settings and dataset names from examples on the develop branch. Removed 'local_maxima' option from the SiPM and Sum HitFinder YAMLs since it was not present in the develop branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we merged fsd_cosmic_sim into develop in larnd-sim, should we do the same here?