fix(post): Prevent failure on parsing - #24
Open
chouetz wants to merge 1 commit into
Open
Conversation
quentinus95
approved these changes
Aug 7, 2026
quentinus95
left a comment
quentinus95
left a comment
There was a problem hiding this comment.
Approving but I am surprised there is no way to mandate that the full response fits into a specific schema, I thought it was a solved problem (or maybe something we could ask the model to iterate on if we fail to parse the output)
Comment on lines
+76
to
+77
| // Scan backward from the last } to find its depth-matching { so that stray | ||
| // brace pairs in prose before the JSON block (e.g. `Foo{}`) are skipped. |
There was a problem hiding this comment.
If I understand well we are doing this because we expect to receive a bunch of text before the JSON, and want to ignore it?
If yes is it because we cannot force a schema on the response?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
https://datadoghq.atlassian.net/browse/ACIX-1750
Fix this failed workflow
Type of change
The model's final message wasn't pure JSON — it had explanatory text with an early stray brace pair, and the action's brace-slicing heuristic grabbed the wrong start point.
We improve the pattern matching to prevent this
Checklist
README.mdif this change affects behaviour or inputs