Skip to content

[SINT-5243] Move macOS signing steps to a protected environment#280

Merged
chouetz merged 1 commit into
mainfrom
kserrania/sint-int-move-macos-secrets-protected-env
May 26, 2026
Merged

[SINT-5243] Move macOS signing steps to a protected environment#280
chouetz merged 1 commit into
mainfrom
kserrania/sint-int-move-macos-secrets-protected-env

Conversation

@KSerrania
Copy link
Copy Markdown
Collaborator

Overview

Migrates macOS package signing to a protected environment running only on main and tags, leaving the ability for non-main builds to create unsigned and non-notarized packages.

Mirrors what was done in ddqa in DataDog/ddqa#141 and DataDog/ddqa#153. The main difference is the need to have two sets of certificates: one to sign binaries, and one to sign the pkg file.

@KSerrania KSerrania requested a review from a team as a code owner May 26, 2026 08:32
@KSerrania KSerrania changed the title [SINT-INT] Move macOS signing steps to a protected environment [SINT-5243] Move macOS signing steps to a protected environment May 26, 2026
@datadog-official
Copy link
Copy Markdown

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 70.93% (-0.01%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 3498f36 | Docs | Datadog PR Page | Give us feedback!

Copy link
Copy Markdown
Member

@chouetz chouetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM, thanks a lot!

@chouetz chouetz merged commit d942eee into main May 26, 2026
27 checks passed
@chouetz chouetz deleted the kserrania/sint-int-move-macos-secrets-protected-env branch May 26, 2026 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants