Skip to content

[CXP-2637] Baseline process_config.run_in_core_agent.enabled on Linux#47902

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 14 commits intomainfrom
daniel.tafoya/baseline-run-in-core-agent
Mar 18, 2026
Merged

[CXP-2637] Baseline process_config.run_in_core_agent.enabled on Linux#47902
gh-worker-dd-mergequeue-cf854d[bot] merged 14 commits intomainfrom
daniel.tafoya/baseline-run-in-core-agent

Conversation

@daniel-taf
Copy link
Copy Markdown
Contributor

@daniel-taf daniel-taf commented Mar 17, 2026

Summary

  • Remove the process_config.run_in_core_agent.enabled config key entirely. On Linux, process checks (process, container, RT container, process discovery) now always run in the core agent — no config toggle.
  • Introduce a build-tag-based platform helper ProcessChecksRunInCoreAgent() in pkg/process/util/ that returns true on Linux and false on other platforms, preserving non-Linux behavior unchanged.
  • Clean up redundant E2E tests and config fixtures that existed only to test the now-removed toggle.

Test plan

  • All affected unit tests pass in dev container (pkg/process/checks, comp/process/agent, comp/core/profiler/impl, pkg/config/setup, pkg/process/metadata/workloadmeta/collector)
  • Compile check passes for all modified packages
  • No remaining references to the config key in Go source files
  • E2E tests pass in CI (Docker, ECS, Fargate, K8s)

🤖 Generated with Claude Code

@daniel-taf daniel-taf requested review from a team as code owners March 17, 2026 01:13
@github-actions github-actions Bot added the long review PR is complex, plan time to review it label Mar 17, 2026
@dd-octo-sts dd-octo-sts Bot added team/agent-runtimes team/agent-discovery team/ecs-experiences Issues and PRs owned by the ECS Experiences team team/container-platform The Container Platform Team labels Mar 17, 2026
@daniel-taf daniel-taf added qa/skip-qa qa/done QA done before merge and regressions are covered by tests changelog/no-changelog No changelog entry needed and removed qa/skip-qa labels Mar 17, 2026
@agent-platform-auto-pr
Copy link
Copy Markdown
Contributor

agent-platform-auto-pr Bot commented Mar 17, 2026

Go Package Import Differences

Baseline: eb09c31
Comparison: 0c9dd46

binaryosarchchange
agentlinuxamd64
+1, -0
+github.com/DataDog/datadog-agent/pkg/process/util/coreagent
agentlinuxarm64
+1, -0
+github.com/DataDog/datadog-agent/pkg/process/util/coreagent
agentwindowsamd64
+1, -0
+github.com/DataDog/datadog-agent/pkg/process/util/coreagent
agentdarwinamd64
+1, -0
+github.com/DataDog/datadog-agent/pkg/process/util/coreagent
agentdarwinarm64
+1, -0
+github.com/DataDog/datadog-agent/pkg/process/util/coreagent
iot-agentlinuxamd64
+1, -0
+github.com/DataDog/datadog-agent/pkg/process/util/coreagent
iot-agentlinuxarm64
+1, -0
+github.com/DataDog/datadog-agent/pkg/process/util/coreagent
heroku-agentlinuxamd64
+1, -0
+github.com/DataDog/datadog-agent/pkg/process/util/coreagent
cluster-agentlinuxamd64
+1, -0
+github.com/DataDog/datadog-agent/pkg/process/util/coreagent
cluster-agentlinuxarm64
+1, -0
+github.com/DataDog/datadog-agent/pkg/process/util/coreagent
cluster-agent-cloudfoundrylinuxamd64
+1, -0
+github.com/DataDog/datadog-agent/pkg/process/util/coreagent
cluster-agent-cloudfoundrylinuxarm64
+1, -0
+github.com/DataDog/datadog-agent/pkg/process/util/coreagent
process-agentlinuxamd64
+1, -0
+github.com/DataDog/datadog-agent/pkg/process/util/coreagent
process-agentlinuxarm64
+1, -0
+github.com/DataDog/datadog-agent/pkg/process/util/coreagent
process-agentwindowsamd64
+1, -0
+github.com/DataDog/datadog-agent/pkg/process/util/coreagent
process-agentdarwinamd64
+1, -0
+github.com/DataDog/datadog-agent/pkg/process/util/coreagent
process-agentdarwinarm64
+1, -0
+github.com/DataDog/datadog-agent/pkg/process/util/coreagent
heroku-process-agentlinuxamd64
+1, -0
+github.com/DataDog/datadog-agent/pkg/process/util/coreagent
otel-agentlinuxamd64
+1, -0
+github.com/DataDog/datadog-agent/pkg/process/util/coreagent
otel-agentlinuxarm64
+1, -0
+github.com/DataDog/datadog-agent/pkg/process/util/coreagent

@daniel-taf daniel-taf changed the title Baseline process_config.run_in_core_agent.enabled on Linux [CXP-2637] Baseline process_config.run_in_core_agent.enabled on Linux Mar 17, 2026
@agent-platform-auto-pr
Copy link
Copy Markdown
Contributor

agent-platform-auto-pr Bot commented Mar 17, 2026

Files inventory check summary

File checks results against ancestor 49cc033d:

Results for datadog-agent_7.78.0~devel.git.681.0c9dd46.pipeline.103220928-1_amd64.deb:

No change detected

@agent-platform-auto-pr
Copy link
Copy Markdown
Contributor

agent-platform-auto-pr Bot commented Mar 17, 2026

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor eb09c31
📊 Static Quality Gates Dashboard
🔗 SQG Job

Successful checks

Info

Quality gate Change Size (prev → curr → max)
agent_deb_amd64 -8.28 KiB (0.00% reduction) 750.067 → 750.059 → 750.720
agent_deb_amd64_fips -12.28 KiB (0.00% reduction) 708.424 → 708.412 → 711.230
agent_heroku_amd64 -4.16 KiB (0.00% reduction) 312.800 → 312.796 → 320.580
agent_msi -7.0 KiB (0.00% reduction) 602.475 → 602.468 → 1062.520
agent_rpm_amd64 -8.28 KiB (0.00% reduction) 750.051 → 750.043 → 750.690
agent_rpm_amd64_fips -12.28 KiB (0.00% reduction) 708.408 → 708.396 → 711.210
agent_rpm_arm64 -16.28 KiB (0.00% reduction) 728.570 → 728.554 → 732.890
agent_rpm_arm64_fips -4.28 KiB (0.00% reduction) 689.874 → 689.870 → 694.440
agent_suse_amd64 -8.28 KiB (0.00% reduction) 750.051 → 750.043 → 750.690
agent_suse_amd64_fips -12.28 KiB (0.00% reduction) 708.408 → 708.396 → 711.210
agent_suse_arm64 -16.28 KiB (0.00% reduction) 728.570 → 728.554 → 732.890
agent_suse_arm64_fips -4.28 KiB (0.00% reduction) 689.874 → 689.870 → 694.440
docker_agent_amd64 -8.28 KiB (0.00% reduction) 810.398 → 810.390 → 813.040
docker_agent_arm64 -16.28 KiB (0.00% reduction) 813.718 → 813.702 → 819.570
docker_agent_jmx_amd64 -8.28 KiB (0.00% reduction) 1001.313 → 1001.305 → 1003.920
docker_agent_jmx_arm64 -16.28 KiB (0.00% reduction) 993.412 → 993.397 → 999.170
docker_cluster_agent_amd64 -4.0 KiB (0.00% reduction) 203.684 → 203.680 → 206.270
iot_agent_deb_amd64 -8.16 KiB (0.02% reduction) 43.065 → 43.058 → 43.290
iot_agent_deb_arm64 -4.16 KiB (0.01% reduction) 40.124 → 40.120 → 40.920
iot_agent_deb_armhf -8.06 KiB (0.02% reduction) 40.860 → 40.852 → 41.030
iot_agent_rpm_amd64 -8.16 KiB (0.02% reduction) 43.066 → 43.058 → 43.290
iot_agent_suse_amd64 -8.16 KiB (0.02% reduction) 43.066 → 43.058 → 43.290
9 successful checks with minimal change (< 2 KiB)
Quality gate Current Size
docker_cluster_agent_arm64 218.167 MiB
docker_cws_instrumentation_amd64 7.142 MiB
docker_cws_instrumentation_arm64 6.689 MiB
docker_dogstatsd_amd64 39.199 MiB
docker_dogstatsd_arm64 37.445 MiB
dogstatsd_deb_amd64 29.846 MiB
dogstatsd_deb_arm64 27.995 MiB
dogstatsd_rpm_amd64 29.846 MiB
dogstatsd_suse_amd64 29.846 MiB
On-wire sizes (compressed)
Quality gate Change Size (prev → curr → max)
agent_deb_amd64 +12.27 KiB (0.01% increase) 174.490 → 174.502 → 177.700
agent_deb_amd64_fips +13.96 KiB (0.01% increase) 165.366 → 165.379 → 172.230
agent_heroku_amd64 -7.36 KiB (0.01% reduction) 74.894 → 74.887 → 79.970
agent_msi -32.0 KiB (0.02% reduction) 137.734 → 137.703 → 146.220
agent_rpm_amd64 +2.75 KiB (0.00% increase) 177.319 → 177.321 → 180.780
agent_rpm_amd64_fips neutral 167.417 MiB → 173.370
agent_rpm_arm64 -25.48 KiB (0.02% reduction) 159.804 → 159.779 → 161.610
agent_rpm_arm64_fips -8.12 KiB (0.01% reduction) 151.480 → 151.472 → 155.910
agent_suse_amd64 +2.75 KiB (0.00% increase) 177.319 → 177.321 → 180.780
agent_suse_amd64_fips neutral 167.417 MiB → 173.370
agent_suse_arm64 -25.48 KiB (0.02% reduction) 159.804 → 159.779 → 161.610
agent_suse_arm64_fips -8.12 KiB (0.01% reduction) 151.480 → 151.472 → 155.910
docker_agent_amd64 -3.02 KiB (0.00% reduction) 267.632 → 267.629 → 271.240
docker_agent_arm64 -27.35 KiB (0.01% reduction) 254.929 → 254.902 → 259.800
docker_agent_jmx_amd64 neutral 336.274 MiB → 339.870
docker_agent_jmx_arm64 -32.2 KiB (0.01% reduction) 319.569 → 319.538 → 324.390
docker_cluster_agent_amd64 +2.79 KiB (0.00% increase) 71.288 → 71.291 → 72.920
docker_cluster_agent_arm64 -6.13 KiB (0.01% reduction) 66.926 → 66.920 → 68.220
docker_cws_instrumentation_amd64 neutral 2.999 MiB → 3.330
docker_cws_instrumentation_arm64 neutral 2.729 MiB → 3.090
docker_dogstatsd_amd64 neutral 15.151 MiB → 15.820
docker_dogstatsd_arm64 neutral 14.473 MiB → 14.830
dogstatsd_deb_amd64 neutral 7.884 MiB → 8.790
dogstatsd_deb_arm64 neutral 6.770 MiB → 7.710
dogstatsd_rpm_amd64 neutral 7.894 MiB → 8.800
dogstatsd_suse_amd64 neutral 7.894 MiB → 8.800
iot_agent_deb_amd64 -4.79 KiB (0.04% reduction) 11.353 → 11.348 → 12.040
iot_agent_deb_arm64 -2.46 KiB (0.02% reduction) 9.665 → 9.662 → 10.450
iot_agent_deb_armhf neutral 9.894 MiB → 10.620
iot_agent_rpm_amd64 -5.11 KiB (0.04% reduction) 11.369 → 11.364 → 12.060
iot_agent_suse_amd64 -5.11 KiB (0.04% reduction) 11.369 → 11.364 → 12.060

@cit-pr-commenter-54b7da
Copy link
Copy Markdown

cit-pr-commenter-54b7da Bot commented Mar 17, 2026

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 7727c8da-fa52-4748-b769-5ee5c02a6547

Baseline: bbb6db2
Comparison: 15b3097
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization +6.91 [+3.78, +10.03] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization +6.91 [+3.78, +10.03] 1 Logs
quality_gate_idle memory utilization +0.54 [+0.49, +0.59] 1 Logs bounds checks dashboard
otlp_ingest_logs memory utilization +0.43 [+0.34, +0.53] 1 Logs
ddot_metrics_sum_cumulative memory utilization +0.30 [+0.16, +0.44] 1 Logs
quality_gate_idle_all_features memory utilization +0.07 [+0.04, +0.11] 1 Logs bounds checks dashboard
file_to_blackhole_0ms_latency egress throughput +0.03 [-0.47, +0.52] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.01 [-0.39, +0.40] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.00 [-0.22, +0.23] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.11, +0.11] 1 Logs
uds_dogstatsd_to_api_v3 ingress throughput -0.02 [-0.21, +0.18] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.02 [-0.10, +0.06] 1 Logs
docker_containers_memory memory utilization -0.02 [-0.10, +0.05] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.05 [-0.47, +0.38] 1 Logs
ddot_metrics memory utilization -0.05 [-0.23, +0.13] 1 Logs
ddot_logs memory utilization -0.08 [-0.14, -0.03] 1 Logs
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization -0.14 [-0.20, -0.08] 1 Logs
otlp_ingest_metrics memory utilization -0.18 [-0.33, -0.02] 1 Logs
file_tree memory utilization -0.25 [-0.31, -0.20] 1 Logs
ddot_metrics_sum_cumulativetodelta_exporter memory utilization -0.28 [-0.51, -0.06] 1 Logs
ddot_metrics_sum_delta memory utilization -0.30 [-0.46, -0.13] 1 Logs
quality_gate_metrics_logs memory utilization -1.05 [-1.29, -0.82] 1 Logs bounds checks dashboard
tcp_syslog_to_blackhole ingress throughput -1.62 [-1.76, -1.49] 1 Logs
quality_gate_logs % cpu utilization -2.65 [-4.20, -1.11] 1 Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed observed_value links
docker_containers_cpu simple_check_run 10/10 575 ≥ 26
docker_containers_memory memory_usage 10/10 270.76MiB ≤ 370MiB
docker_containers_memory simple_check_run 10/10 691 ≥ 26
file_to_blackhole_0ms_latency memory_usage 10/10 0.19GiB ≤ 1.20GiB
file_to_blackhole_0ms_latency missed_bytes 10/10 0B = 0B
file_to_blackhole_1000ms_latency memory_usage 10/10 0.23GiB ≤ 1.20GiB
file_to_blackhole_1000ms_latency missed_bytes 10/10 0B = 0B
file_to_blackhole_100ms_latency memory_usage 10/10 0.19GiB ≤ 1.20GiB
file_to_blackhole_100ms_latency missed_bytes 10/10 0B = 0B
file_to_blackhole_500ms_latency memory_usage 10/10 0.22GiB ≤ 1.20GiB
file_to_blackhole_500ms_latency missed_bytes 10/10 0B = 0B
quality_gate_idle intake_connections 10/10 3 = 3 bounds checks dashboard
quality_gate_idle memory_usage 10/10 174.42MiB ≤ 175MiB bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 2 ≤ 3 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 489.14MiB ≤ 550MiB bounds checks dashboard
quality_gate_logs intake_connections 10/10 4 ≤ 6 bounds checks dashboard
quality_gate_logs memory_usage 10/10 204.17MiB ≤ 220MiB bounds checks dashboard
quality_gate_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 355.04 ≤ 2000 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 4 ≤ 6 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 398.29MiB ≤ 475MiB bounds checks dashboard
quality_gate_metrics_logs missed_bytes 10/10 0B = 0B bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.

Copy link
Copy Markdown
Member

@davidor davidor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for files owned by container-platform (just 1 file)

Comment on lines -9 to -10
run_in_core_agent:
enabled: false
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing there was a reason it was set to false, so just removing it would make the test fail

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you can enable a config which makes the process-agent run on Linux that should fix it

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the NPM config to turn on the process-agent and that did fix it.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks !

@daniel-taf daniel-taf force-pushed the daniel.tafoya/baseline-run-in-core-agent branch from fefe0f2 to 0f39319 Compare March 18, 2026 09:35
daniel-taf and others added 14 commits March 18, 2026 09:39
On Linux, process checks (process, container, RT container, process discovery)
now always run in the core agent. The `process_config.run_in_core_agent.enabled`
config key is removed entirely — the behavior is no longer optional.

A build-tag-based platform helper `ProcessChecksRunInCoreAgent()` in
`pkg/process/util/` returns `true` on Linux and `false` on other platforms,
preserving non-Linux behavior unchanged.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Move the helper from pkg/process/util (which transitively pulls in
go4.org/netipx) to a new zero-dependency leaf package
pkg/process/util/coreagent. This avoids adding unnecessary imports to
binaries like cluster-agent-cloudfoundry and otel-agent.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
On Linux, the process-agent no longer runs standalone (process checks
are in the core agent). Update E2E and unit tests that expected the
process-agent to be running:

- Remove process-agent from auth_artifact agentProcesses list on Linux
- Remove WithProcessAgentOnPort from Linux IPC and config-refresh tests
- Make assertAgentsUseKey platform-aware (includeProcessAgent param)
- Make container/RT container check tests platform-aware using
  coreagent.ProcessChecksRunInCoreAgent()

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Address review feedback: instead of removing process-agent from tests,
enable NPM (network_config.enabled + system_probe_config.enabled) in
the IPC, auth_artifact, and config-refresh test fixtures so that the
process-agent starts on Linux for connections check. This preserves
IPC auth coverage for process-agent.

Reverts the assertAgentsUseKey signature change — no longer needed
since process-agent is now running in all test environments.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The "Process Agent Enabled" and "Process Agent Enabled, Alternate
Setting" test cases tested the profiler timeout when process checks
run in a standalone process-agent. This scenario no longer exists on
Linux, and the "Process Agent Checks in Core Agent" test already
covers the current behavior.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Update assertRunningChecks to combine enabled checks from both
  ProcessAgentStatus and ProcessComponentStatus, since process checks
  now run in the core agent on Linux while connections runs in the
  standalone process-agent.
- Fix K8s test assertions to check ProcessComponentStatus for
  process/discovery checks.
- Move NPM config from datadog.yaml to system-probe.yaml via
  WithSystemProbeConfig in IPC, auth_artifact, and config-refresh
  Linux tests so the process-agent starts for IPC testing.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Remove shouldStayAlive() from process-agent: the process-agent no
  longer needs to stay alive idle in K8s to prevent crash loops.
  When disabled, it exits immediately.
- Remove duplicate E2E tests that existed only to test the
  now-removed core agent toggle:
  - docker: TestProcessChecksInCoreAgentWithNPM
  - linux: TestProcessChecksInCoreAgent, TestProcessChecksInCoreAgentWithNPM
  - k8s: entire K8sCoreAgentSuite (TestProcessCheckInCoreAgent)
- Move K8s NPM test to K8sSuite.TestProcessCheckWithNPM (unique test).
- Fix assertRunningChecks expected values for remaining tests.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The Helm chart deploys a process-agent container regardless. Without
shouldStayAlive, the process-agent exits immediately when it has no
checks to run, causing CrashLoopBackOff in K8s.

Simplified from the original: no longer checks the removed config key,
just checks env.IsKubernetes().

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The Helm chart's doNotCheckTag logic prevents automatic detection of
agent version >=7.60, causing it to deploy the process-agent container
even when process checks run in the core agent. shouldStayAlive keeps
this container from crash-looping.

Changed from Warn to Info since this is expected behavior, not a
misconfiguration. Added TODO to remove once the chart is updated.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
On Linux, process checks run in the core agent. Update manual check
tests to use `datadog-agent processchecks` / `agent processchecks`
instead of `process-agent check`:
- linux_test.go: 3 tests updated, removed duplicate TestManualProcessCheckCoreAgent
- docker_test.go: 3 tests updated
- k8s_test.go: execProcessAgentCheck helper updated

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@daniel-taf daniel-taf force-pushed the daniel.tafoya/baseline-run-in-core-agent branch from 0f39319 to 0c9dd46 Compare March 18, 2026 09:40
// in the core agent. The process-agent stays alive idle to prevent the container from crash-looping.
// TODO: remove this once the Helm chart no longer deploys the process-agent container when
// runInCoreAgent is enabled (the chart's doNotCheckTag logic prevents automatic detection).
func shouldStayAlive() bool {
Copy link
Copy Markdown
Contributor Author

@daniel-taf daniel-taf Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wante to remove this, but we cannot quite yet. The Helm chart auto-detects agent >=7.60 to skip deploying the process-agent container. But the E2E tests set doNotCheckTag: true in the chart, which disables the version check. The chart falls through to deploying the process-agent container even though it's not needed. Causing issues for some tests that check liveness of containers. We need some changes on the chart-side to remove this.

@daniel-taf daniel-taf requested a review from pgimalac March 18, 2026 10:41
Copy link
Copy Markdown
Member

@pgimalac pgimalac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for Agent Runtimes !

Comment on lines -9 to -10
run_in_core_agent:
enabled: false
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog No changelog entry needed internal Identify a non-fork PR long review PR is complex, plan time to review it qa/done QA done before merge and regressions are covered by tests team/agent-build team/agent-configuration team/agent-discovery team/agent-runtimes team/container-experiences team/container-platform The Container Platform Team team/ecs-experiences Issues and PRs owned by the ECS Experiences team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants