Stop installing dd-pkg at runtime#51161
Conversation
|
@codex review |
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1a0b6ea3cd
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| # - Verify the build image provides `dd-pkg`, logging the version in use for the job | ||
| .setup_dd_pkg: | ||
| - curl --retry 5 -sSL "https://dd-package-tools.s3.amazonaws.com/dd-pkg/${DD_PKG_VERSION}/dd-pkg_Linux_${DD_PKG_ARCH}.tar.gz" | tar -xz -C /usr/local/bin dd-pkg | ||
| - dd-pkg version |
There was a problem hiding this comment.
Switching .setup_dd_pkg from runtime install to just dd-pkg version makes every job that references it fail immediately when the selected image lacks the binary (GitLab stops on non-zero script commands). In this same commit, no CI_IMAGE_LINUX, CI_IMAGE_GITLAB_AGENT_DEPLOY, or CI_IMAGE_RPM_ARMHF values are updated, yet those images are used by packaging/deploy/release jobs that call .setup_dd_pkg (for example in .gitlab/build/packaging/{deb,rpm}.yml, .gitlab/deploy/deploy_packages/deploy_common.yml, and .gitlab/distribute/trigger_release/*.yml), so merging this change before image bumps will break those pipelines with dd-pkg: command not found.
Useful? React with 👍 / 👎.
Gitlab CI Configuration Changes
|
| Removed | Modified | Added | Renamed |
|---|---|---|---|
| 0 | 101 | 0 | 0 |
Updated: .gitlab/distribution.yml
Changes Summary
| Removed | Modified | Added | Renamed |
|---|---|---|---|
| 0 | 8 | 0 | 0 |
ℹ️ Diff available in the job log.
AliDatadog
force-pushed
the
codex-require-preinstalled-dd-pkg
branch
from
1a0b6ea to
e718cc2
Compare
AliDatadog
added
changelog/no-changelog
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep them coming! ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
1 participant
What does this PR do?
Stop installing
dd-pkgat runtime in Agent CI..setup_dd_pkgnow only runsdd-pkg version, so jobs fail fast if the build image does not provide the CLI.DD_PKG_VERSIONand the per-jobDD_PKG_ARCHvariables that only existed to download the runtime tarball.dd-pkgupload, lint, sign, and promote usage unchanged.Motivation
dd-pkgshould be part of the build images instead of being downloaded during every CI job. The corresponding buildimages change has merged: DataDog/datadog-agent-buildimages#1176.Rollout dependency
Keep this PR draft until the Agent build image variables point at buildimages that include
dd-pkg.The relevant image families are:
CI_IMAGE_LINUXCI_IMAGE_GITLAB_AGENT_DEPLOYCI_IMAGE_RPM_ARMHFJira: https://datadoghq.atlassian.net/browse/BARX-1747
Describe how you validated your changes
git diff --checkdda inv linter.gitlab-ci --test=alldda inv invoke-unit-tests.run --tests gitlab_api --directory tasks/unit_testsgitlab-configurationpassed while updating the branch.Additional Notes
This intentionally keeps
DD_PKG_GITLAB_URLand all actualdd-pkgcommand usage. Only the runtime installation path was removed.