Adds CICD skill#51164
Conversation
|
@codex review |
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 54c9be67af
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
|
||
| ### Internal Staging Images (`internal_image_deploy` stage) | ||
|
|
||
| **Job:** `publish_internal_container_image-full` |
There was a problem hiding this comment.
The guide instructs users to trigger publish_internal_container_image-full, but that job is not defined in our pipeline config; .gitlab/deploy/internal_image_deploy/internal_image_deploy.yml defines publish_internal_container_image-jmx, publish_internal_container_image-fips, and related variants (lines 73-121). Following this instruction will send users looking for a non-existent manual job and block the intended staging publish flow.
Useful? React with 👍 / 👎.
| Variables to set: | ||
| ``` | ||
| IMAGE_NAME = datadog-agent | ||
| IMAGE_VERSION = tmpl-v7 |
There was a problem hiding this comment.
For manual DataDog/images pipelines, this skill sets IMAGE_NAME=datadog-agent with IMAGE_VERSION=tmpl-v7, but the current internal deploy config pins datadog-agent to IMAGE_VERSION: tmpl-v23 (.gitlab/deploy/internal_image_deploy/internal_image_deploy.yml lines 51-54). Using tmpl-v7 here targets the wrong template/version and can cause the manual publish pipeline to fail or produce the wrong artifact set.
Useful? React with 👍 / 👎.
|
|
||
| **Job:** `publish_internal_container_image-full` | ||
| **Output:** `registry.ddbuild.io/images/datadog-agent:<branch-name>-full` | ||
| **Trigger:** Manual, but **ONLY available in deploy pipelines** |
There was a problem hiding this comment.
The statement that internal image jobs are “ONLY available in deploy pipelines” is inaccurate for current CI rules: internal image jobs use .on_deploy_internal_or_internal_image_change_or_manual (.gitlab/deploy/internal_image_deploy/internal_image_deploy.yml line 8), and that rule set includes a general manual fallback (.gitlab-ci.yml lines 583-596). This can misdiagnose missing-job situations and send users down the wrong troubleshooting path.
Useful? React with 👍 / 👎.
Files inventory check summaryFile checks results against ancestor 611b67bd: Results for datadog-agent_7.81.0~devel.git.145.54c9be6.pipeline.114501753-1_amd64.deb:No change detected |
1 participant
Claude code skill to help query and navigate the gitlab and github CI