test(service-test): capture user-mode dumps on SCM-kill via SilentProcessExit#51168
Draft
clarkb7 wants to merge 1 commit into
Draft
test(service-test): capture user-mode dumps on SCM-kill via SilentProcessExit#51168clarkb7 wants to merge 1 commit into
clarkb7 wants to merge 1 commit into
Conversation
Configure the agent service binaries (datadog-installer.exe, agent.exe, trace-agent.exe, process-agent.exe, security-agent.exe, system-probe.exe) for Windows SilentProcessExit monitoring so SCM start/stop timeouts produce a user-mode minidump of the hung process. WER LocalDumps only covers unhandled-exception crashes, leaving externally-initiated TerminateProcess calls (which is how SCM kills hung services) without a dump. IgnoreSelfExits=1 keeps normal Stop iterations quiet. DumpType=2 (full memory) so Go runtime state is recoverable for early-startup hangs. SilentProcessExit dumps land in <LocalDumpFolder>\<image>-(PID-<pid>)-<seq>\ rather than flat alongside WER dumps. Extend ListWERDumps to walk one level deep and parseWERDumpFilePath to recognize the "<image>-(PID-<pid>).dmp" filename format so the existing DownloadAllWERDumps collection picks them up without changes at the call site.
clarkb7
added
changelog/no-changelog
Contributor
|
@codex review |
github-actions
Bot
added
the
short review
Contributor
|
|
Codex Review: Didn't find any major issues. Hooray! ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
Contributor
Files inventory check summaryFile checks results against ancestor 90df1df6: Results for datadog-agent_7.81.0~devel.git.146.c148b4e.pipeline.114520302-1_amd64.deb:No change detected |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Enables SilentProcessExit for the agent service binaries so SCM-kills (start/stop timeouts) produce a user-mode minidump. Extends
ListWERDumps/parseWERDumpFilePathto also pick up the SilentProcessExit on-disk layout so the existing collection path works unchanged.Motivation
WINA-2707: installer hung in early Go-runtime init and SCM killed it after 30 s. WER LocalDumps only fires on unhandled exceptions,
DD_CRASH_ON_HARDSTOP_TIMEOUTrequires the service handler to be registered, and the kernelLiveDump.dmp(#50964) is taken minutes after the user-mode process is gone. SilentProcessExit dumps from insideNtTerminateProcesswhile threads are still walkable.