packaging/aix: unset OBJECT_MODE before Go external linker in stage 04#51170
Open
pgimalac wants to merge 1 commit into
Open
packaging/aix: unset OBJECT_MODE before Go external linker in stage 04#51170pgimalac wants to merge 1 commit into
pgimalac wants to merge 1 commit into
Conversation
pgimalac
added
changelog/no-changelog
Contributor
|
@codex review |
github-actions
Bot
added
the
short review
|
Codex Review: Didn't find any major issues. Keep them coming! ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
Contributor
|
jeremy-hanna
approved these changes
May 21, 2026
Contributor
Files inventory check summaryFile checks results against ancestor b7c4f46b: Results for datadog-agent_7.81.0~devel.git.148.9806971.pipeline.114525733-1_amd64.deb:No change detected |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds
unset OBJECT_MODEin stage 04 immediately before invoking the Go external linker.Motivation
When both
OBJECT_MODE=64andAIX_OBJECT_MODE=64are exported simultaneously, the Go external linker invocation fails with:OBJECT_MODE=64is needed globally for tools likearthat don't respectAIX_OBJECT_MODE(e.g. bzip2's Makefile callsar cqwithout-X64, which defaults to 32-bit mode withoutOBJECT_MODE=64).AIX_OBJECT_MODE=64alone is sufficient for gcc-8 to select the correct 64-bit startup file (/lib/crt0_64.o) for the Go link step.Describe how you validated your changes
Validated locally: with
OBJECT_MODE=64kept globally, bzip2 and OpenSSL build correctly; withunset OBJECT_MODEin stage 04, the Go external linker links successfully.Additional Notes
N/A