Skip to content

Add datadog_csi_driver to AGENT_CORECHECKS#51172

Open
adel121 wants to merge 1 commit into
mainfrom
adelhajhassan/add_datadog_csi_driver_to_agentcorechecks_tasks
Open

Add datadog_csi_driver to AGENT_CORECHECKS#51172
adel121 wants to merge 1 commit into
mainfrom
adelhajhassan/add_datadog_csi_driver_to_agentcorechecks_tasks

Conversation

@adel121
Copy link
Copy Markdown
Contributor

@adel121 adel121 commented May 21, 2026

What does this PR do?

Add datadog_csi_driver to AGENT_CORECHECKS so that it is shipped in /etc/datadog-agent/conf.d/datadog_csi_driver.d

It also adds auto_conf.yml which was previously missing.

Motivation

These issues were masked previously because the python check had been shipping the auto_config.yml.

But now we are dropping the python integration completely in order to:

  • avoid redundancy
  • reduce agent size

Describe how you validated your changes

Built custom image of the agent and verified the files are shipped correctly and the csi driver check runs successfully by default.

Additional Notes

Also tried to set an unsupported flag in the check config, and it worked without issues:

ad_identifiers:
  - csi-driver
init_config:
instances:
  - openmetrics_endpoint: http://%%host%%:5000/metrics
    request_size: 20

Running Checks
  ==============

    datadog_csi_driver
    ------------------
      Instance ID: datadog_csi_driver [OK]
      Configuration Source: file:/etc/datadog-agent/conf.d/datadog_csi_driver.d/auto_conf.yaml[0]
      Total Runs: 1
      Metric Samples: Last Run: 0, Total: 0
      Events: Last Run: 0, Total: 0
      Service Checks: Last Run: 1, Total: 1
      Average Execution Time : 1ms
      Last Execution Date : 2026-05-21 15:09:24.18 UTC (1779376164180)
      Last Successful Execution Date : 2026-05-21 15:09:24 UTC (1779376164000)

To validate that this works without the python side, I built the custom agent image against 7.65.1 which didn't include the python check, and validated the check config is loaded and running successfully.

@adel121 adel121 requested review from a team as code owners May 21, 2026 15:23
@adel121 adel121 requested a review from s-alad May 21, 2026 15:23
@adel121 adel121 added this to the 7.80.0 milestone May 21, 2026
@adel121 adel121 added changelog/no-changelog No changelog entry needed qa/done QA done before merge and regressions are covered by tests labels May 21, 2026
@dd-octo-sts dd-octo-sts Bot added internal Identify a non-fork PR team/agent-configuration labels May 21, 2026
@github-actions github-actions Bot added the short review PR is simple enough to be reviewed quickly label May 21, 2026
"container_lifecycle",
"cpu",
"cri",
"datadog_csi_driver",
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to reviewers:

I am not sure if this should have been updated as well, but it looked inline with tasks/core_checks.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog No changelog entry needed internal Identify a non-fork PR qa/done QA done before merge and regressions are covered by tests short review PR is simple enough to be reviewed quickly team/agent-build team/agent-configuration team/agent-devx

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants