chore(serializer): remove unused serializer_max_series_points_per_payload setting#51178
Open
tobz wants to merge 1 commit into
Open
chore(serializer): remove unused serializer_max_series_points_per_payload setting#51178tobz wants to merge 1 commit into
serializer_max_series_points_per_payload setting#51178tobz wants to merge 1 commit into
Conversation
Contributor
|
rayz
approved these changes
May 21, 2026
dustmop
approved these changes
May 21, 2026
songy23
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
As stated in the PR title.
Motivation
serializer_max_series_points_per_payloadwas originally added in #11496 in order to add limits related to the new v2 series API, where there previously were no limits. Hard to divine intent from a six-year old PR, written by an engineer who no longer works here, but conceptually we can imagine that the only reason to change this would be if we wanted to change the limits to improve intake processing efficiency somehow.However, we would do this by changing the default and not asking every Datadog customer to change it... which strongly implies that this should simply be a constant, rather than a tunable.
This is further bolstered by the fact that based on our internal usage data, only a single Agent installation out in the wild has this set to something other than the default value.
Describe how you validated your changes
Existing unit tests.
Additional Notes