Skip to content

chore(serializer): remove unused serializer_max_series_points_per_payload setting#51178

Open
tobz wants to merge 1 commit into
mainfrom
tobz/remove-max-series-points-per-payload-tunable
Open

chore(serializer): remove unused serializer_max_series_points_per_payload setting#51178
tobz wants to merge 1 commit into
mainfrom
tobz/remove-max-series-points-per-payload-tunable

Conversation

@tobz
Copy link
Copy Markdown
Member

@tobz tobz commented May 21, 2026

What does this PR do?

As stated in the PR title.

Motivation

serializer_max_series_points_per_payload was originally added in #11496 in order to add limits related to the new v2 series API, where there previously were no limits. Hard to divine intent from a six-year old PR, written by an engineer who no longer works here, but conceptually we can imagine that the only reason to change this would be if we wanted to change the limits to improve intake processing efficiency somehow.

However, we would do this by changing the default and not asking every Datadog customer to change it... which strongly implies that this should simply be a constant, rather than a tunable.

This is further bolstered by the fact that based on our internal usage data, only a single Agent installation out in the wild has this set to something other than the default value.

Describe how you validated your changes

Existing unit tests.

Additional Notes

@tobz tobz requested review from a team as code owners May 21, 2026 17:34
@tobz tobz requested review from dustmop and truthbk and removed request for a team May 21, 2026 17:34
@github-actions github-actions Bot added the medium review PR review might take time label May 21, 2026
@datadog-datadog-prod-us1
Copy link
Copy Markdown
Contributor

datadog-datadog-prod-us1 Bot commented May 21, 2026

Pipelines

Fix all issues with BitsAI

⚠️ Warnings

🚦 3 Pipeline jobs failed

Label analysis | release-note-check   View in Datadog   GitHub Actions

🛟 This job is unlikely to succeed on retry. Please review your pipeline configuration. Release note not found for this PR. Please add one using 'reno' or apply the label 'changelog/no-changelog'.

Label analysis | skip-qa-check   View in Datadog   GitHub Actions

🛟 This job is unlikely to succeed on retry. Please review your pipeline configuration. Missing required QA label for pull request validation.

Label analysis | team-label-check   View in Datadog   GitHub Actions

🛟 This job is unlikely to succeed on retry. Please review your pipeline configuration. Missing required labels for PR 51178. At least one 'team/' label is necessary.

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 4aa36b8 | Docs | Datadog PR Page | Give us feedback!

@tobz tobz added ask-review Ask required teams to review this PR and removed medium review PR review might take time team/agent-configuration team/agent-metric-pipelines internal Identify a non-fork PR labels May 21, 2026
@tobz tobz added qa/skip-qa changelog/no-changelog No changelog entry needed qa/done QA done before merge and regressions are covered by tests and removed qa/skip-qa labels May 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ask-review Ask required teams to review this PR changelog/no-changelog No changelog entry needed qa/done QA done before merge and regressions are covered by tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants