Skip to content

chore(aggregator): set title on Agent lifecycle event#51179

Open
rayz wants to merge 1 commit into
mainfrom
rayz/add-title-agent-lifecycle-event
Open

chore(aggregator): set title on Agent lifecycle event#51179
rayz wants to merge 1 commit into
mainfrom
rayz/add-title-agent-lifecycle-event

Conversation

@rayz
Copy link
Copy Markdown
Contributor

@rayz rayz commented May 21, 2026

What does this PR do?

Populates title for the agent's lifecycle events (startup and shutdown)

Motivation

ECT-5537

Describe how you validated your changes

  1. Run the agent and shutdown gracefully.
  2. Observe that the events in Datadog have titles.

Additional Notes

@rayz rayz added this to the 7.81.0 milestone May 21, 2026
@rayz rayz requested a review from a team as a code owner May 21, 2026 18:19
@rayz rayz added changelog/no-changelog No changelog entry needed qa/done QA done before merge and regressions are covered by tests labels May 21, 2026
@github-actions github-actions Bot added the short review PR is simple enough to be reviewed quickly label May 21, 2026
@datadog-datadog-prod-us1-2
Copy link
Copy Markdown
Contributor

datadog-datadog-prod-us1-2 Bot commented May 21, 2026

Pipelines

Fix all issues with BitsAI

⚠️ Warnings

🚦 2 Pipeline jobs failed

DataDog/datadog-agent | new-e2e-ha-agent-failover   View in Datadog   GitLab

🔄 Retry job. This looks flaky and may succeed on retry. 2 assertions failed: Error: Could not fetch metadata payload: Get "https://localhost:5001/agent/metadata/ha-agent": dial tcp 127.0.0.1:5001: connect: connection refused; and Error: could not reach agent: Get "https://localhost:5001/agent/status/section/collector?format=text": dial tcp 127.0.0.1:5001: connect: connection refused

DataDog/datadog-agent | oracle: [21.3.0-xe]   View in Datadog   GitLab

🛟 This job is unlikely to succeed on retry. Please review your pipeline configuration. Failed to ping Oracle instance: ORA-12514: TNS:listener does not currently know of service requested in connect descriptor.

ℹ️ Info

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 50.35% (-0.01%)

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 5d2698c | Docs | Datadog PR Page | Give us feedback!

@dd-octo-sts
Copy link
Copy Markdown
Contributor

dd-octo-sts Bot commented May 21, 2026

Files inventory check summary

File checks results against ancestor d7dc449a:

Results for datadog-agent_7.81.0~devel.git.152.5d2698c.pipeline.114571739-1_amd64.deb:

No change detected

@dd-octo-sts
Copy link
Copy Markdown
Contributor

dd-octo-sts Bot commented May 21, 2026

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor d7dc449
📊 Static Quality Gates Dashboard
🔗 SQG Job

Successful checks

Info

Quality gate Change Size (prev → curr → max)
dogstatsd_deb_arm64 +4.0 KiB (0.01% increase, -0.38% of buffer) 28.268 → 28.272 → 29.290
31 successful checks with minimal change (< 2 KiB)
Quality gate Current Size
agent_deb_amd64 745.244 MiB
agent_deb_amd64_fips 703.018 MiB
agent_heroku_amd64 310.138 MiB
agent_rpm_amd64 745.228 MiB
agent_rpm_amd64_fips 703.002 MiB
agent_rpm_arm64 722.788 MiB
agent_rpm_arm64_fips 683.728 MiB
agent_suse_amd64 745.228 MiB
agent_suse_amd64_fips 703.002 MiB
agent_suse_arm64 722.788 MiB
agent_suse_arm64_fips 683.728 MiB
docker_agent_amd64 805.385 MiB
docker_agent_arm64 807.766 MiB
docker_agent_jmx_amd64 996.305 MiB
docker_agent_jmx_arm64 987.464 MiB
docker_cluster_agent_amd64 206.995 MiB
docker_cluster_agent_arm64 220.952 MiB
docker_cws_instrumentation_amd64 7.154 MiB
docker_cws_instrumentation_arm64 6.689 MiB
docker_dogstatsd_amd64 39.487 MiB
docker_dogstatsd_arm64 37.690 MiB
docker_host_profiler_amd64 302.188 MiB
docker_host_profiler_arm64 313.677 MiB
dogstatsd_deb_amd64 30.143 MiB
dogstatsd_rpm_amd64 30.143 MiB
dogstatsd_suse_amd64 30.143 MiB
iot_agent_deb_amd64 44.578 MiB
iot_agent_deb_arm64 41.539 MiB
iot_agent_deb_armhf 42.247 MiB
iot_agent_rpm_amd64 44.578 MiB
iot_agent_suse_amd64 44.578 MiB

@cit-pr-commenter-54b7da
Copy link
Copy Markdown

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: a2ff373c-1370-4dd3-b47d-51ab6577939b

Baseline: d7dc449
Comparison: 5d2698c
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization +1.08 [-1.87, +4.02] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_metrics_logs memory utilization +1.96 [+1.71, +2.21] 1 Logs bounds checks dashboard
docker_containers_cpu % cpu utilization +1.08 [-1.87, +4.02] 1 Logs
quality_gate_idle_all_features memory utilization +0.32 [+0.26, +0.38] 1 Logs bounds checks dashboard
ddot_metrics_sum_cumulativetodelta_exporter memory utilization +0.22 [-0.01, +0.46] 1 Logs
ddot_metrics_sum_delta memory utilization +0.08 [-0.10, +0.26] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.03 [-0.17, +0.23] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.03 [-0.44, +0.50] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.02 [-0.08, +0.11] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.01 [-0.50, +0.52] 1 Logs
uds_dogstatsd_to_api_v3 ingress throughput -0.00 [-0.21, +0.21] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.00 [-0.14, +0.13] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.01 [-0.41, +0.39] 1 Logs
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization -0.02 [-0.07, +0.03] 1 Logs
file_tree memory utilization -0.12 [-0.16, -0.07] 1 Logs
docker_containers_memory memory utilization -0.14 [-0.24, -0.04] 1 Logs
quality_gate_idle memory utilization -0.16 [-0.21, -0.11] 1 Logs bounds checks dashboard
ddot_logs memory utilization -0.21 [-0.26, -0.16] 1 Logs
tcp_syslog_to_blackhole ingress throughput -0.22 [-0.40, -0.04] 1 Logs
ddot_metrics_sum_cumulative memory utilization -0.30 [-0.45, -0.15] 1 Logs
ddot_metrics memory utilization -0.40 [-0.60, -0.20] 1 Logs
otlp_ingest_logs memory utilization -0.44 [-0.54, -0.34] 1 Logs
quality_gate_logs % cpu utilization -0.49 [-1.49, +0.52] 1 Logs bounds checks dashboard
otlp_ingest_metrics memory utilization -0.88 [-1.03, -0.72] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed observed_value links
docker_containers_cpu simple_check_run 10/10 577 ≥ 26
docker_containers_memory memory_usage 10/10 244.69MiB ≤ 370MiB
docker_containers_memory simple_check_run 10/10 720 ≥ 26
file_to_blackhole_0ms_latency memory_usage 10/10 0.16GiB ≤ 1.20GiB
file_to_blackhole_0ms_latency missed_bytes 10/10 0B = 0B
file_to_blackhole_1000ms_latency memory_usage 10/10 0.20GiB ≤ 1.20GiB
file_to_blackhole_1000ms_latency missed_bytes 10/10 0B = 0B
file_to_blackhole_100ms_latency memory_usage 10/10 0.17GiB ≤ 1.20GiB
file_to_blackhole_100ms_latency missed_bytes 10/10 0B = 0B
file_to_blackhole_500ms_latency memory_usage 10/10 0.18GiB ≤ 1.20GiB
file_to_blackhole_500ms_latency missed_bytes 10/10 0B = 0B
quality_gate_idle intake_connections 10/10 3 ≤ 4 bounds checks dashboard
quality_gate_idle memory_usage 10/10 142.65MiB ≤ 147MiB bounds checks dashboard
quality_gate_idle total_bytes_received 10/10 740.48KiB ≤ 819.20KiB bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 2 ≤ 4 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 428.97MiB ≤ 495MiB bounds checks dashboard
quality_gate_idle_all_features total_bytes_received 10/10 1.12MiB ≤ 1.25MiB bounds checks dashboard
quality_gate_logs intake_connections 10/10 4 ≤ 6 bounds checks dashboard
quality_gate_logs memory_usage 10/10 176.56MiB ≤ 195MiB bounds checks dashboard
quality_gate_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
quality_gate_logs total_bytes_received 10/10 264.34MiB ≤ 292MiB bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 347.21 ≤ 2000 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 4 ≤ 6 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 392.38MiB ≤ 430MiB bounds checks dashboard
quality_gate_metrics_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
quality_gate_metrics_logs total_bytes_received 10/10 0.93GiB ≤ 1.04GiB bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog No changelog entry needed internal Identify a non-fork PR qa/done QA done before merge and regressions are covered by tests short review PR is simple enough to be reviewed quickly team/agent-metric-pipelines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants