perf(preprocessor): 3 Go tokenizer pipeline optimizations#51181
perf(preprocessor): 3 Go tokenizer pipeline optimizations#51181DDuongNguyen wants to merge 1 commit into
Conversation
1. JSON fast-reject: looksLikeJSON() checks first non-whitespace byte before calling json.Valid(). Non-JSON messages skip parsing entirely. 10x faster for non-JSON (990ns → 99ns), 7x on mixed corpus. 2. IsMatch length pre-filter: couldMatch() rejects pattern candidates by token count ratio before full token-by-token comparison. ~4% faster on sampler scan path. 3. Index zero-copy: Tokenize() returns indices as a view into internal buffer instead of allocating a fresh slice. Callers only read indices (in limitTokensToBytes), never store them. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
@codex review |
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 133e44ce96
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| if !couldMatch(len(e.tokens), tokLen, s.config.MatchThreshold) { | ||
| continue | ||
| } |
There was a problem hiding this comment.
couldMatch is used here as a hard gate before IsMatch, but it is not equivalent to IsMatch’s matching rules: IsMatch compares only min(lenA,lenB) tokens and can return true even when lengths differ a lot (see TestIsMatch case where a long sequence matches "!" at threshold 1.0). With this prefilter, those previously valid matches are now skipped whenever shorter/longer < MatchThreshold (e.g., default 0.9), so logs with optional/variable suffixes are treated as new patterns, reducing sampling effectiveness and causing unnecessary pattern-table churn.
Useful? React with 👍 / 👎.
Files inventory check summaryFile checks results against ancestor e14f24c6: Results for datadog-agent_7.81.0~devel.git.58.133e44c.pipeline.114602139-1_amd64.deb:No change detected |
Static quality checks✅ Please find below the results from static quality gates Successful checksInfo
28 successful checks with minimal change (< 2 KiB)
|
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: e14f24c Optimization Goals: ✅ No significant changes detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | docker_containers_cpu | % cpu utilization | +0.38 | [-2.55, +3.30] | 1 | Logs |
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | quality_gate_metrics_logs | memory utilization | +1.22 | [+0.96, +1.47] | 1 | Logs bounds checks dashboard |
| ➖ | ddot_logs | memory utilization | +0.53 | [+0.46, +0.60] | 1 | Logs |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | +0.41 | [+0.22, +0.59] | 1 | Logs |
| ➖ | docker_containers_cpu | % cpu utilization | +0.38 | [-2.55, +3.30] | 1 | Logs |
| ➖ | docker_containers_memory | memory utilization | +0.26 | [+0.16, +0.36] | 1 | Logs |
| ➖ | file_to_blackhole_100ms_latency | egress throughput | +0.03 | [-0.10, +0.16] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api_v3 | ingress throughput | +0.03 | [-0.17, +0.22] | 1 | Logs |
| ➖ | uds_dogstatsd_20mb_12k_contexts_20_senders | memory utilization | +0.01 | [-0.04, +0.06] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | +0.00 | [-0.20, +0.21] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.00 | [-0.10, +0.09] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency | egress throughput | -0.01 | [-0.44, +0.41] | 1 | Logs |
| ➖ | file_to_blackhole_500ms_latency | egress throughput | -0.05 | [-0.45, +0.35] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency | egress throughput | -0.06 | [-0.56, +0.44] | 1 | Logs |
| ➖ | quality_gate_idle_all_features | memory utilization | -0.11 | [-0.14, -0.07] | 1 | Logs bounds checks dashboard |
| ➖ | quality_gate_logs | % cpu utilization | -0.19 | [-1.20, +0.81] | 1 | Logs bounds checks dashboard |
| ➖ | quality_gate_idle | memory utilization | -0.20 | [-0.25, -0.15] | 1 | Logs bounds checks dashboard |
| ➖ | otlp_ingest_metrics | memory utilization | -0.20 | [-0.35, -0.05] | 1 | Logs |
| ➖ | otlp_ingest_logs | memory utilization | -0.33 | [-0.42, -0.24] | 1 | Logs |
| ➖ | ddot_metrics_sum_cumulativetodelta_exporter | memory utilization | -0.34 | [-0.58, -0.10] | 1 | Logs |
| ➖ | ddot_metrics_sum_cumulative | memory utilization | -0.51 | [-0.67, -0.35] | 1 | Logs |
| ➖ | ddot_metrics | memory utilization | -0.52 | [-0.72, -0.32] | 1 | Logs |
| ➖ | file_tree | memory utilization | -0.53 | [-0.57, -0.48] | 1 | Logs |
| ➖ | ddot_metrics_sum_delta | memory utilization | -0.57 | [-0.75, -0.39] | 1 | Logs |
Bounds Checks: ✅ Passed
| perf | experiment | bounds_check_name | replicates_passed | observed_value | links |
|---|---|---|---|---|---|
| ✅ | docker_containers_cpu | simple_check_run | 10/10 | 531 ≥ 26 | |
| ✅ | docker_containers_memory | memory_usage | 10/10 | 251.01MiB ≤ 370MiB | |
| ✅ | docker_containers_memory | simple_check_run | 10/10 | 692 ≥ 26 | |
| ✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | 0.16GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_0ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | 0.20GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_1000ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | 0.17GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_100ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | 0.18GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_500ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | quality_gate_idle | intake_connections | 10/10 | 3 ≤ 4 | bounds checks dashboard |
| ✅ | quality_gate_idle | memory_usage | 10/10 | 144.66MiB ≤ 147MiB | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | intake_connections | 10/10 | 3 ≤ 4 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | 471.64MiB ≤ 495MiB | bounds checks dashboard |
| ✅ | quality_gate_logs | intake_connections | 10/10 | 3 ≤ 6 | bounds checks dashboard |
| ✅ | quality_gate_logs | memory_usage | 10/10 | 177.16MiB ≤ 195MiB | bounds checks dashboard |
| ✅ | quality_gate_logs | missed_bytes | 10/10 | 0B = 0B | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | cpu_usage | 10/10 | 357.40 ≤ 2000 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | intake_connections | 10/10 | 3 ≤ 6 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | memory_usage | 10/10 | 399.44MiB ≤ 430MiB | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | missed_bytes | 10/10 | 0B = 0B | bounds checks dashboard |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
1 participant
Summary
looksLikeJSON()checks first byte beforejson.Valid()— 10x faster for non-JSON messagescouldMatch()rejects by token count before full comparison — 4% faster sampler scanTokenize()returns indices as buffer view, eliminating 1 alloc per call — 24% faster tokenizerTest plan
🤖 Generated with Claude Code