Fix consecutive-acronym handling in generated examples#1530
Open
Fix consecutive-acronym handling in generated examples#1530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes broken imports in generated examples when an OpenAPI tag contains consecutive acronyms (e.g.
Bits AI SRE).The library file (
api_bits_ai_sre.rs) generates correctly becausecli.pysnake_cases the raw tag. But the example template re-snake_cased the spaceless formBitsAISRE(set in conftest from the BDD.featurefile), which producedapi_bits_aisre.Changes:
templates/example.j2: snake_case the raw tag (raw_tag) instead of the spacelessname, in both theformat_parameters(api=…)call and theuseimport..generator/conftest.py: stash the raw tag incontext["api_instance"]so the template can use it.Behavior is unchanged for any tag without consecutive acronyms.
Test plan
Bits AI→Bits AI SREin.generator/schemas/v2/openapi.yamland ran./generate.sh.Links