use dd-trace-go 1.74.6 (A transition to dd-trace-go/V2)#210
Conversation
| assert.Equal(t, "aws.lambda", finishedSpan.OperationName()) | ||
|
|
||
| assert.Equal(t, true, finishedSpan.Tag("cold_start")) | ||
| assert.Equal(t, "true", finishedSpan.Tag("cold_start")) |
There was a problem hiding this comment.
This value was indeed updated to a string
joeyzhao2018
changed the title
purple4reina
left a comment
purple4reina
left a comment
There was a problem hiding this comment.
Thanks for the update. Users could technically upgrade to v1.74.x of dd-trace-go without this. For example, our e2e tests have been doing so for a while.
|
We should actually be really careful about releasing this, and in fact, I'm not so sure we should. For a customer who is using the v1 tracer to create custom spans, this change will break their traces. Therefore, this update is actually not backward compatible. It is a breaking change. If we are planning to move this code to dd-trace-go, as you stated in the weekly planning update in slack, why then do we even need to make this change? |
|
Okay, I read your doc and saw that you tested using both v1 and v2 tracer with this branch. I stand corrected. This would not be a breaking change. So, I guess what I'm saying now is, this change isn't necessary, but I'm not opposed to doing it. |
|
Thanks for all the comments. I'm going to merge it just to make it easier to reason about the versions. |
2 participants
https://datadoghq.atlassian.net/browse/APMSVLS-171
What does this PR do?
Update the dependency dd-trace-go version from 1.73.1 to 1.74.6.
This is important although it's just a minor version update, because 1.74 is a
forward compatibilityversion (as it uses v2 via an adapter). In other words, customers can use dd-trace-go v2 along with it without breaking any trace.For example, you can
import "github.com/DataDog/dd-trace-go/v2/ddtrace/tracer"and create a custom spanspan, ctx := tracer.StartSpanFromContext(ctx, "custom-using-v2")and still connected in one trace. (which would be broken with <=1.73)Motivation
Testing Guidelines
Tested in real apps to validate the forward compatibility as shown in the graph above. The v2 APIs usage itself is also tested in dd-trace-go.
Additional Notes
Types of changes
Checklist