Skip to content

add datadog-origin header#215

Merged
ojproductions merged 1 commit into
mainfrom
onzia/add-origin-header
Oct 16, 2025
Merged

add datadog-origin header#215
ojproductions merged 1 commit into
mainfrom
onzia/add-origin-header

Conversation

@ojproductions
Copy link
Copy Markdown
Contributor

@ojproductions ojproductions commented Sep 23, 2025

What does this PR do?

Adds the datadog-origin header to context if its present in given event headers or extension context

As noted in Issue #189, in the case of synthetics, if the origin header isnt present in the extractTextMap function in dd-trace-go, an ErrSpanContextNotFound error occurs due to the missing origin:
image

By including datadog origin header, we fix this:
image

Motivation

Issue #189
APMSVLS-1

Testing Guidelines

I created some unit tests and updated existing ones. Also ran lamba functions to see if expected header was present

Additional Notes

Types of changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Checklist

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog

@ojproductions ojproductions requested a review from a team as a code owner September 23, 2025 15:30
@ojproductions ojproductions changed the title add multivalue headers resolves #189 add datadog-origin header resolves #189 Sep 23, 2025
@joeyzhao2018
Copy link
Copy Markdown
Contributor

joeyzhao2018 commented Sep 26, 2025

Also ran lamba functions to see if expected header was present

nitpik for this: it would be nice to have some screenshots or links to view, validate and understand. In this specific case, I was wondering where the headers are showing in the UI? is it a tag of a span?

Comment thread internal/trace/constants.go
@ojproductions ojproductions changed the title add datadog-origin header resolves #189 add datadog-origin header Oct 7, 2025
Copy link
Copy Markdown
Contributor

@joeyzhao2018 joeyzhao2018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ojproductions ojproductions merged commit eb2176f into main Oct 16, 2025
9 checks passed
@ojproductions ojproductions deleted the onzia/add-origin-header branch October 16, 2025 13:19
@ojproductions ojproductions restored the onzia/add-origin-header branch October 16, 2025 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants