[CONTP-1656] Add datadog instrumentation crd rbac perms#2975
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2975 +/- ##
==========================================
+ Coverage 41.39% 41.58% +0.18%
==========================================
Files 331 331
Lines 28911 28926 +15
==========================================
+ Hits 11969 12029 +60
+ Misses 16086 16041 -45
Partials 856 856
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 94c51f1bd6
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| rbac.PatchVerb, | ||
| rbac.UpdateVerb, |
There was a problem hiding this comment.
Remove write verbs from datadoginstrumentations parent resource
This rule grants patch/update on datadoginstrumentations itself, which allows the Cluster Agent to modify spec/metadata of any DatadogInstrumentation object cluster-wide; for status reconciliation, Kubernetes only needs write access on the datadoginstrumentations/status subresource. In environments where the Cluster Agent should be read-only for instrumentation definitions, this is an unnecessary privilege escalation and should be limited to get/list/watch on the parent resource.
Useful? React with 👍 / 👎.
731ec1b to
3fd7689
Compare
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
This pull request was merged directly. |
What does this PR do?
Gives the cluster agent necessary RBAC permissions to
get/list/watchtheDatadogInstrumentationCRD andupdate/patchthe status section of the CRD.Motivation
Follow up #2962
Describe your test plan
Checklist
bug,enhancement,refactoring,documentation,tooling, and/ordependenciesqa/skip-qalabel