Skip to content

Detect enclosing function for JavaScript#883

Draft
xaldama wants to merge 1 commit into
xabier.aldama/detect_method_pythonfrom
xabier.aldama/detect_method_javascript
Draft

Detect enclosing function for JavaScript#883
xaldama wants to merge 1 commit into
xabier.aldama/detect_method_pythonfrom
xabier.aldama/detect_method_javascript

Conversation

@xaldama

@xaldama xaldama commented Apr 20, 2026

Copy link
Copy Markdown

Summary

  • Implements enclosing function detection for JavaScript (FQN format: ClassName.methodName for class methods, functionName for top-level functions and variable-assigned arrow/anonymous functions)
  • Named function expressions use the explicit function name; anonymous functions assigned to a variable use the variable name

Test plan

  • Unit tests in javascript/methods.rs cover function declarations, class methods, arrow functions, anonymous functions, named function expressions, and unassigned anonymous functions

@xaldama xaldama requested a review from a team as a code owner April 20, 2026 13:30
@xaldama xaldama requested review from gillarramendi and removed request for a team April 20, 2026 13:30
@datadog-prod-us1-3

datadog-prod-us1-3 Bot commented Apr 20, 2026

Copy link
Copy Markdown

🎯 Code Coverage (details)
Patch Coverage: 92.81%
Overall Coverage: 85.13% (+0.05%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: a807906 | Docs | Datadog PR Page | Give us feedback!

@xaldama xaldama marked this pull request as draft April 20, 2026 13:43
@xaldama xaldama force-pushed the xabier.aldama/detect_method_python branch from 3c7761a to 905d45d Compare April 20, 2026 14:07
@xaldama xaldama force-pushed the xabier.aldama/detect_method_javascript branch from 4dda14b to a807906 Compare April 20, 2026 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant