Use highest version as baseline#11714
Conversation
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
|
/gitlab resync-job-status --bypass-required-checks-syncing-strategy |
|
View all feedbacks in Devflow UI.
404 Not Found DetailsIf you need support, contact us on Slack #ci-infra-support with those details! |
|
/merge -f --reason "Only changing GHA workflows, so no need to run MQ tests" |
|
View all feedbacks in Devflow UI.
The expected merge time in
Warning This change was merged without running any pre merge CI checks Reason: Only changing GHA workflows, so no need to run MQ tests |
What Does This Do
When there are multiple versions for a dependency set across multiple lockfiles, use the highest of these versions as the baseline.
Motivation
In #11712, there was an issue that a too-new version of
logback-corewas not reverted properly. This is because there are multiple versions oflogback-coreset across lockfiles, and the baseline was not defined as the newest of these set versions. Thus,1.5.34(the version to revert to) was calculated as anew_gavhere, but since it was in thebaseline_coordsset, the revert was skipped here. The change in this PR addresses the issue such that we should no longer be able to calculate anew_gavthat's already in thebaseline_coordsset.Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issue/merge. You can also:/merge --commit-message "..."/merge -c/merge -f --reason "reason"; please use this judiciously, as some checks do not run at the PR-level (note: the PR still needs to be mergeable, this will only skip the pre-merge build)Jira ticket: [PROJ-IDENT]