Skip to content

haproxy: add container-based config discovery support#24153

Closed
martavicentenavarro wants to merge 4 commits into
vitkyrka/disco-config-fullfrom
marta/discovery-haproxy
Closed

haproxy: add container-based config discovery support#24153
martavicentenavarro wants to merge 4 commits into
vitkyrka/disco-config-fullfrom
marta/discovery-haproxy

Conversation

@martavicentenavarro

Copy link
Copy Markdown

What does this PR do?

Adds container-based config discovery support to the haproxy integration. Files added/modified:

  • haproxy/assets/configuration/spec.yaml: declares the discovery block with the haproxy AD identifier, using the from_ports strategy to probe port 8404. When a matching container is detected, the Agent schedules an OpenMetrics check against http://%%host%%:8404/metrics.
  • haproxy/datadog_checks/haproxy/config_models/discovery.py: autogenerated candidates function implementing the from_ports strategy.
  • haproxy/datadog_checks/haproxy/data/auto_conf.yaml: autogenerated autodiscovery configuration.

Motivation

Part of DSCVR-485 — rolling out configuration discovery support to integrations-core integrations, so the Agent can automatically detect and configure the check when a matching container is running.

Port reference: https://www.haproxy.com/documentation/haproxy-configuration-tutorials/alerts-and-monitoring/prometheus/

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add qa/required if this PR needs QA validation, or qa/skip-qa if it does not. Exactly one of the two is required.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@martavicentenavarro martavicentenavarro added the qa/skip-qa Automatically skip this PR for the next QA label Jun 23, 2026
@datadog-prod-us1-3

datadog-prod-us1-3 Bot commented Jun 23, 2026

Copy link
Copy Markdown

Tests  Code Coverage

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 94.45% (+6.51%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: a5492ec | Docs | Datadog PR Page | Give us feedback!

@dd-octo-sts

dd-octo-sts Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Validation Report

All 21 validations passed.

Show details
Validation Description Status
agent-reqs Verify check versions match the Agent requirements file
ci Validate CI configuration and code coverage settings
codeowners Validate every integration has a CODEOWNERS entry
config Validate default configuration files against spec.yaml
dep Verify dependency pins are consistent and Agent-compatible
http Validate integrations use the HTTP wrapper correctly
imports Validate check imports do not use deprecated modules
integration-style Validate check code style conventions
jmx-metrics Validate JMX metrics definition files and config
labeler Validate PR labeler config matches integration directories
legacy-signature Validate no integration uses the legacy Agent check signature
license-headers Validate Python files have proper license headers
licenses Validate third-party license attribution list
metadata Validate metadata.csv metric definitions
models Validate configuration data models match spec.yaml
openmetrics Validate OpenMetrics integrations disable the metric limit
package Validate Python package metadata and naming
qa-label Validate the pull request declares whether it needs QA for the next Agent release
readmes Validate README files have required sections
saved-views Validate saved view JSON file structure and fields
version Validate version consistency between package and changelog

View full run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation integration/haproxy qa/skip-qa Automatically skip this PR for the next QA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant