haproxy: add container-based config discovery support#24153
Closed
martavicentenavarro wants to merge 4 commits into
Closed
haproxy: add container-based config discovery support#24153martavicentenavarro wants to merge 4 commits into
martavicentenavarro wants to merge 4 commits into
Conversation
🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: a5492ec | Docs | Datadog PR Page | Give us feedback! |
Contributor
Validation ReportAll 21 validations passed. Show details
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds container-based config discovery support to the haproxy integration. Files added/modified:
haproxy/assets/configuration/spec.yaml: declares the discovery block with thehaproxyAD identifier, using thefrom_portsstrategy to probe port 8404. When a matching container is detected, the Agent schedules an OpenMetrics check againsthttp://%%host%%:8404/metrics.haproxy/datadog_checks/haproxy/config_models/discovery.py: autogenerated candidates function implementing thefrom_portsstrategy.haproxy/datadog_checks/haproxy/data/auto_conf.yaml: autogenerated autodiscovery configuration.Motivation
Part of DSCVR-485 — rolling out configuration discovery support to integrations-core integrations, so the Agent can automatically detect and configure the check when a matching container is running.
Port reference: https://www.haproxy.com/documentation/haproxy-configuration-tutorials/alerts-and-monitoring/prometheus/
Review checklist (to be filled by reviewers)
qa/requiredif this PR needs QA validation, orqa/skip-qaif it does not. Exactly one of the two is required.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged