Fetch AIA intermediate certificates with credential-free HTTP sessions#24154
Draft
dkirov-dd wants to merge 10 commits into
Draft
Fetch AIA intermediate certificates with credential-free HTTP sessions#24154dkirov-dd wants to merge 10 commits into
dkirov-dd wants to merge 10 commits into
Conversation
The Authority Information Access CA Issuers URI comes from the peer certificate and is untrusted. Previously it was fetched with the instance's configured HTTP session, which could leak the instance's credentials, auth headers, client certs, or proxy settings to an attacker-controlled endpoint (VULN-1192). Fetch the URI with a fresh, credential-free session instead: attempt secure TLS first, then fall back to plain HTTP, never carrying the instance's auth configuration. Caching, recursion, and cert loading are preserved.
|
199c72e to
b3e1af0
Compare
Contributor
Validation Report
Run Passed validations (20)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fetches AIA (Authority Information Access) intermediate certificates using fresh, credential-free HTTP sessions.
The primary fix is in the shared base HTTP wrapper:
RequestsWrapper.load_intermediate_certs()now fetches the certificate's AIA CA Issuers URI with a new cleanRequestsWrapperinstead of reusing the configured wrapper. Each fetch attempts secure TLS first, then falls back to a no-verify plain HTTP path, and disables proxy inheritance for the AIA fetch session.The TLS integration has a separate AIA chasing implementation, so this PR applies the same credential-free fetching pattern there as well. Existing caching, recursion, hashing/dedup, and certificate loading behavior are preserved.
The
fetch_intermediate_certsoption behavior is unchanged: it was already respected, and its default remainsfalse.Motivation
Security case VULN-1192: AIA chasing should not reuse an integration instance's configured HTTP session for peer-provided certificate issuer URLs.
Review checklist (to be filled by reviewers)
qa/requiredif this PR needs QA validation, orqa/skip-qaif it does not. Exactly one of the two is required.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged