Skip to content

Allow OAuth on pup security restriction-policies #524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
platinummonkey merged 1 commit into from
May 22, 2026
+23 −4
Merged

Allow OAuth on pup security restriction-policies #524

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/commands/security.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -645,7 +645,7 @@ pub async fn asm_exclusions_delete(cfg: &Config, exclusion_filter_id: &str) -> R
// ---- Restriction Policies ----

pub async fn restriction_policy_get(cfg: &Config, resource_id: &str) -> Result<()> {
let api = crate::make_api_no_auth!(RestrictionPoliciesAPI, cfg);
let api = crate::make_api!(RestrictionPoliciesAPI, cfg);
let resp = api
.get_restriction_policy(resource_id.to_string())
.await
Expand All @@ -655,7 +655,7 @@ pub async fn restriction_policy_get(cfg: &Config, resource_id: &str) -> Result<(

pub async fn restriction_policy_update(cfg: &Config, resource_id: &str, file: &str) -> Result<()> {
let body: RestrictionPolicyUpdateRequest = util::read_json_file(file)?;
let api = crate::make_api_no_auth!(RestrictionPoliciesAPI, cfg);
let api = crate::make_api!(RestrictionPoliciesAPI, cfg);
let resp = api
.update_restriction_policy(
resource_id.to_string(),
Expand All @@ -668,7 +668,7 @@ pub async fn restriction_policy_update(cfg: &Config, resource_id: &str, file: &s
}

pub async fn restriction_policy_delete(cfg: &Config, resource_id: &str) -> Result<()> {
let api = crate::make_api_no_auth!(RestrictionPoliciesAPI, cfg);
let api = crate::make_api!(RestrictionPoliciesAPI, cfg);
api.delete_restriction_policy(resource_id.to_string())
.await
.map_err(|e| anyhow::anyhow!("failed to delete restriction policy: {e:?}"))?;
Expand Down
21 changes: 20 additions & 1 deletion src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4566,7 +4566,26 @@ enum SecurityActions {
action: AsmExclusionActions,
},
/// Manage resource restriction policies
#[command(name = "restriction-policies")]
///
/// Restriction policies live at `/api/v2/restriction_policy/{resource}`
/// where `{resource}` is `<type>:<id>` (ex: `dashboard:abc-123`,
/// `monitor:12345`). The server accepts OAuth2 or DD_API_KEY +
/// DD_APP_KEY.
///
/// The required OAuth scope depends on the resource type embedded in
/// the resource ID. The server enforces the same permission a user would
/// need to view/edit the underlying resource (ex: `dashboards_read` for
/// a `dashboard:*` GET, `monitors_write` for a `monitor:*` POST).
///
/// Common types covered by pup's default OAuth scopes today: dashboard,
/// monitor, slo, workflow, notebook, security-rule, logs-archive,
/// rum-application, reference-table, case-management-project,
/// on-call-*, status-page, integration-*. Other resource types (ex:
/// connection, app-builder-app, obs-pipelines-*, spreadsheet,
/// feature-flag, agent-builder-agent, product-analytics-*) require
/// scopes pup does not yet request; for those, use DD_API_KEY +
/// DD_APP_KEY.
#[command(name = "restriction-policies", verbatim_doc_comment)]
RestrictionPolicies {
#[command(subcommand)]
action: RestrictionPolicyActions,
Expand Down
Loading