experiment(core): add support for tracking CPU usage on a per-group basis

[tobz]

Summary

Work in progress.

Change Type

• Bug fix
• New feature
• Non-functional (chore, refactoring, docs)
• Performance

How did you test this PR?

References

[pr-commenter]

Binary Size Analysis (Agent Data Plane)

Target: 50c6040 (baseline) vs 867670c (comparison) diff
Analysis Type: Stripped binaries (debug symbols excluded)
Baseline Size: 37.54 MiB
Comparison Size: 37.56 MiB
Size Change: +20.51 KiB (+0.05%)
Pass/Fail Threshold: +5%
Result: PASSED ✅

Changes by Module

Module	File Size	Symbols
piecemeal	-13.96 KiB	39
serde_core	+9.23 KiB	807
datadog_protos::trace_piecemeal_include::datadog	+8.71 KiB	20
figment	-8.51 KiB	575
saluki_app::accounting::ResourceGroupMetrics	+7.11 KiB	9
prost	+6.95 KiB	497
saluki_app::memory::AllocationTelemetryWorker	-6.16 KiB	7
saluki_app::memory::AllocationGroupMetrics	-6.13 KiB	8
saluki_app::accounting::ResourceTelemetryWorker	+6.10 KiB	7
saluki_app::accounting::MemoryBoundsConfiguration	+5.77 KiB	3
saluki_app::memory::MemoryBoundsConfiguration	-5.63 KiB	3
std	-5.59 KiB	634
saluki_app::logging::build_output_stack	+5.52 KiB	4
saluki_app::accounting::print_bounds	+5.12 KiB	9
saluki_app::memory::print_bounds	-5.08 KiB	9
saluki_app::accounting::initialize_memory_bounds	+4.90 KiB	5
saluki_app::memory::initialize_memory_bounds	-4.86 KiB	5
h2	+4.75 KiB	904
http	+4.70 KiB	420
tonic	-4.69 KiB	426

Detailed Symbol Changes

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [NEW]  +149Ki  [NEW]  +149Ki    agent_data_plane::cli::run::handle_run_command::_{{closure}}::hd5596d4463b8add4
  [NEW] +67.6Ki  [NEW] +67.5Ki    agent_data_plane::cli::run::create_topology::_{{closure}}::h7c64a9beea827065
  [NEW] +67.5Ki  [NEW] +67.4Ki    agent_data_plane::run_inner::_{{closure}}::h5be7bc128876a44a
  [NEW] +65.3Ki  [NEW] +65.2Ki    saluki_core::topology::built::BuiltTopology::spawn::_{{closure}}::h43f53a9d7aeec7d6
  [NEW] +57.5Ki  [NEW] +57.3Ki    saluki_core::topology::blueprint::TopologyBlueprint::build::_{{closure}}::h868bf0d6faa3fac6
  [NEW] +57.4Ki  [NEW] +57.2Ki    agent_data_plane::internal::env::workload::RemoteAgentWorkloadProvider::from_configuration::_{{closure}}::he6f69a773ec6ab6d
  [NEW] +57.2Ki  [NEW] +57.0Ki    agent_data_plane::cli::debug::handle_debug_command::_{{closure}}::h76e5d7fe59ff2cea
  [NEW] +47.9Ki  [NEW] +47.6Ki    _<saluki_components::transforms::apm_stats::ApmStats as saluki_core::components::transforms::Transform>::run::_{{closure}}::hf09fd2ccd9bf5d88
  [NEW] +40.9Ki  [NEW] +40.7Ki    _<saluki_components::forwarders::otlp::OtlpForwarder as saluki_core::components::forwarders::Forwarder>::run::_{{closure}}::h9c3556b4037c2cad
  [NEW] +39.7Ki  [NEW] +39.6Ki    saluki_components::common::datadog::io::run_endpoint_io_loop::_{{closure}}::h5458061f322ea251
  +0.1% +25.5Ki  +0.1% +20.7Ki    [46908 Others]
  [DEL] -40.1Ki  [DEL] -40.0Ki    saluki_components::common::datadog::io::run_endpoint_io_loop::_{{closure}}::hde4459a01e3f9227
  [DEL] -40.9Ki  [DEL] -40.7Ki    _<saluki_components::forwarders::otlp::OtlpForwarder as saluki_core::components::forwarders::Forwarder>::run::_{{closure}}::h09537e0f77e66173
  [DEL] -50.8Ki  [DEL] -50.6Ki    _<saluki_components::transforms::apm_stats::ApmStats as saluki_core::components::transforms::Transform>::run::_{{closure}}::h43075509d7ce59ea
  [DEL] -57.5Ki  [DEL] -57.3Ki    agent_data_plane::internal::env::workload::RemoteAgentWorkloadProvider::from_configuration::_{{closure}}::hb791ff1a07efb07e
  [DEL] -57.7Ki  [DEL] -57.6Ki    saluki_core::topology::blueprint::TopologyBlueprint::build::_{{closure}}::h3e314072cc66659a
  [DEL] -57.8Ki  [DEL] -57.6Ki    agent_data_plane::cli::debug::handle_debug_command::_{{closure}}::h51e2d17685e5879d
  [DEL] -65.4Ki  [DEL] -65.2Ki    saluki_core::topology::built::BuiltTopology::spawn::_{{closure}}::h8438abea594e7f4b
  [DEL] -68.1Ki  [DEL] -68.0Ki    agent_data_plane::cli::run::create_topology::_{{closure}}::hb2ea473da8501e18
  [DEL] -68.7Ki  [DEL] -68.6Ki    agent_data_plane::run_inner::_{{closure}}::hc6c22ce20d0c6ae6
  [DEL]  -148Ki  [DEL]  -148Ki    agent_data_plane::cli::run::handle_run_command::_{{closure}}::h93dd78edc7b9f901
  +0.1% +20.5Ki  +0.1% +15.7Ki    TOTAL

[pr-commenter]

Regression Detector (Agent Data Plane)

Regression Detector Results

Run ID: 17d3b48e-ab53-45a1-a1f5-e3d0b1bf08e1

Baseline: 50c6040
Comparison: 867670c
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	otlp_ingest_logs_5mb_memory	memory utilization	+4.03	[+3.74, +4.32]	1	(metrics) (profiles) (logs)
➖	otlp_ingest_logs_5mb_cpu	% cpu utilization	+0.86	[-3.46, +5.19]	1	(metrics) (profiles) (logs)
➖	otlp_ingest_logs_5mb_throughput	ingress throughput	-0.00	[-0.12, +0.11]	1	(metrics) (profiles) (logs)

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	otlp_ingest_logs_5mb_memory	memory utilization	+4.03	[+3.74, +4.32]	1	(metrics) (profiles) (logs)
➖	dsd_uds_100mb_3k_contexts_cpu	% cpu utilization	+3.61	[-2.64, +9.86]	1	(metrics) (profiles) (logs)
➖	dsd_uds_10mb_3k_contexts_cpu	% cpu utilization	+2.44	[-28.83, +33.71]	1	(metrics) (profiles) (logs)
➖	dsd_uds_512kb_3k_contexts_cpu	% cpu utilization	+2.24	[-57.49, +61.97]	1	(metrics) (profiles) (logs)
➖	otlp_ingest_traces_5mb_cpu	% cpu utilization	+2.00	[-0.05, +4.04]	1	(metrics) (profiles) (logs)
➖	otlp_ingest_metrics_5mb_memory	memory utilization	+1.76	[+1.54, +1.98]	1	(metrics) (profiles) (logs)
➖	otlp_ingest_traces_ottl_filtering_5mb_cpu	% cpu utilization	+1.70	[-0.69, +4.08]	1	(metrics) (profiles) (logs)
➖	otlp_ingest_logs_5mb_cpu	% cpu utilization	+0.86	[-3.46, +5.19]	1	(metrics) (profiles) (logs)
➖	otlp_ingest_metrics_5mb_cpu	% cpu utilization	+0.53	[-5.59, +6.65]	1	(metrics) (profiles) (logs)
➖	dsd_uds_500mb_3k_contexts_cpu	% cpu utilization	+0.31	[-1.19, +1.80]	1	(metrics) (profiles) (logs)
➖	dsd_uds_500mb_3k_contexts_memory	memory utilization	+0.23	[+0.08, +0.38]	1	(metrics) (profiles) (logs)
➖	otlp_ingest_traces_5mb_memory	memory utilization	+0.19	[+0.02, +0.35]	1	(metrics) (profiles) (logs)
➖	quality_gates_rss_dsd_ultraheavy	memory utilization	+0.17	[+0.03, +0.30]	1	(metrics) (profiles) (logs)
➖	dsd_uds_1mb_3k_contexts_memory	memory utilization	+0.16	[+0.01, +0.31]	1	(metrics) (profiles) (logs)
➖	quality_gates_rss_dsd_low	memory utilization	+0.11	[-0.05, +0.28]	1	(metrics) (profiles) (logs)
➖	quality_gates_rss_idle	memory utilization	+0.06	[+0.01, +0.11]	1	(metrics) (profiles) (logs)
➖	dsd_uds_10mb_3k_contexts_memory	memory utilization	+0.02	[-0.14, +0.17]	1	(metrics) (profiles) (logs)
➖	otlp_ingest_traces_ottl_filtering_5mb_memory	memory utilization	+0.01	[-0.24, +0.26]	1	(metrics) (profiles) (logs)
➖	otlp_ingest_traces_5mb_throughput	ingress throughput	+0.00	[-0.07, +0.07]	1	(metrics) (profiles) (logs)
➖	dsd_uds_1mb_3k_contexts_throughput	ingress throughput	+0.00	[-0.06, +0.06]	1	(metrics) (profiles) (logs)
➖	otlp_ingest_traces_ottl_transform_5mb_throughput	ingress throughput	-0.00	[-0.07, +0.07]	1	(metrics) (profiles) (logs)
➖	dsd_uds_100mb_3k_contexts_throughput	ingress throughput	-0.00	[-0.03, +0.03]	1	(metrics) (profiles) (logs)
➖	otlp_ingest_logs_5mb_throughput	ingress throughput	-0.00	[-0.12, +0.11]	1	(metrics) (profiles) (logs)
➖	otlp_ingest_metrics_5mb_throughput	ingress throughput	-0.01	[-0.17, +0.15]	1	(metrics) (profiles) (logs)
➖	dsd_uds_10mb_3k_contexts_throughput	ingress throughput	-0.01	[-0.18, +0.16]	1	(metrics) (profiles) (logs)
➖	dsd_uds_512kb_3k_contexts_throughput	ingress throughput	-0.01	[-0.06, +0.04]	1	(metrics) (profiles) (logs)
➖	otlp_ingest_traces_ottl_transform_5mb_memory	memory utilization	-0.01	[-0.17, +0.15]	1	(metrics) (profiles) (logs)
➖	otlp_ingest_traces_ottl_filtering_5mb_throughput	ingress throughput	-0.01	[-0.09, +0.06]	1	(metrics) (profiles) (logs)
➖	quality_gates_rss_dsd_medium	memory utilization	-0.04	[-0.21, +0.13]	1	(metrics) (profiles) (logs)
➖	dsd_uds_100mb_3k_contexts_memory	memory utilization	-0.09	[-0.25, +0.06]	1	(metrics) (profiles) (logs)
➖	dsd_uds_512kb_3k_contexts_memory	memory utilization	-0.20	[-0.35, -0.06]	1	(metrics) (profiles) (logs)
➖	quality_gates_rss_dsd_heavy	memory utilization	-0.21	[-0.33, -0.08]	1	(metrics) (profiles) (logs)
➖	otlp_ingest_traces_ottl_transform_5mb_cpu	% cpu utilization	-0.55	[-2.64, +1.54]	1	(metrics) (profiles) (logs)
➖	dsd_uds_1mb_3k_contexts_cpu	% cpu utilization	-0.57	[-56.52, +55.38]	1	(metrics) (profiles) (logs)
➖	dsd_uds_500mb_3k_contexts_throughput	ingress throughput	-1.08	[-1.19, -0.97]	1	(metrics) (profiles) (logs)

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	observed_value	links
✅	quality_gates_rss_dsd_heavy	memory_usage	10/10	122.93MiB ≤ 140MiB	(metrics) (profiles) (logs)
✅	quality_gates_rss_dsd_low	memory_usage	10/10	40.04MiB ≤ 50MiB	(metrics) (profiles) (logs)
✅	quality_gates_rss_dsd_medium	memory_usage	10/10	60.29MiB ≤ 75MiB	(metrics) (profiles) (logs)
✅	quality_gates_rss_dsd_ultraheavy	memory_usage	10/10	178.04MiB ≤ 200MiB	(metrics) (profiles) (logs)
✅	quality_gates_rss_idle	memory_usage	10/10	27.05MiB ≤ 40MiB	(metrics) (profiles) (logs)

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

[tobz]

• experiment(core): add support for tracking CPU usage on a per-group basis #1343 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.