feat(dogstatsd): added replay functionality#1711
Conversation
This comment has been minimized.
This comment has been minimized.
Binary Size Analysis (Agent Data Plane)Baseline: cdcd393 · Comparison: e56b344 · diff ✅ Binary size difference within thresholdChanges by Module
Detailed Symbol Changes |
Regression Detector (Agent Data Plane)Run ID: Optimization Goals: ✅ No significant changes detectedFine details of change detection per experiment (35)Experiments configured
Bounds Checks: ✅ Passed (5)
ExplanationA change is flagged as a regression when |Δ mean %| > 5.00% in the regressing direction for its optimization goal AND SMP marks the experiment as a regression ( |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 93a6fa12e4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| struct TopologyControlSurfaces { | ||
| dogstatsd: Option<DogStatsDControlSurface>, | ||
| } |
There was a problem hiding this comment.
I actually really like this concept of grouping together the necessary types to provide a "control surface" over a given pipeline.
One thing we should do as an immediate follow-up PR, I think, is actually unify this such that we also include the DSD Stats stuff in here as well. I think that would mean moving things around so we basically pass back just the API handler, and create_topology actually creates the component configuration and all of that... but it seems doable.
That would also, I believe, let us remove the need for a separate DogStatsDControlPlaneConfiguration type.
…_blueprint return dsdcontrolsurface
| use saluki_components::sources::{ | ||
| TimestampResolution, TrafficCaptureReader, DEFAULT_REPLAY_LOOPS, REPLAY_CREDENTIALS_GID, | ||
| }; |
There was a problem hiding this comment.
This is definitely a code smell to me, but also it feels non-blocking. I'd say we should follow up by seeing if we can reorganize some of the DSD replay code into datadog-agent-commons.
What
Adds DogStatsD replay support across the staged replay layers:
Why
Replay should preserve the origin/tag attribution from the capture file instead of resolving replayed traffic against the current live workload state.
Validation
cargo check -p saluki-components -p saluki-context -p saluki-io --testsNotes
Opened as draft for human review.