feat(metrics): add series-specific payload limit config#1715
Conversation
|
Regression Detector (Agent Data Plane)Run ID: Optimization Goals: ❌ 1 regression detected
Fine details of change detection per experiment (34)Experiments configured
Bounds Checks: ✅ Passed (5)
ExplanationA change is flagged as a regression when |Δ mean %| > 5.00% in the regressing direction for its optimization goal AND SMP marks the experiment as a regression ( |
| if series_endpoint == MetricsEndpoint::SeriesV2 { | ||
| series_rb.with_len_limits(self.max_series_uncompressed_payload_size, self.max_series_payload_size)?; | ||
| } |
There was a problem hiding this comment.
So this is the main thing that strikes me as insufficient: we should be using the API-enforced limits as an upper bound (min(user_payload_size_limit, api_payload_size_limit))`.
We should never let users send payloads that risk being rejected due to exceeding size limits.
There was a problem hiding this comment.
Also, to that end, I would change the doc comments for the config fields to say that every endpoint has an upper bound that is enforced by the API, and whatever value is specified here (as in: the user-supplied config value) will be clamped to that limit.
.. and then I'd probably also uniformly apply it to the V1 series payloads as well unless those are actually hard-coded in the Agent?
Summary
Adds ADP support for the Agent’s V2 series payload limit configuration keys:
serializer_max_series_payload_sizeserializer_max_series_uncompressed_payload_sizeThese are now wired into the V2 series request builder, moved from unsupported to supported config
registry entries, and reflected in the DogStatsD config docs.
serializer_max_series_points_per_payloadwill not be supported as it will be removed from the Agent config.Change Type
How did you test this PR?
Existing Unit Tests + CI
References