[Java] Enable filenames tests for vertx3, vertx4 and spring-boot-jetty#7201
Merged
Conversation
- Enable Test_Blocking_request_body_filenames for vertx3, vertx4 and spring-boot-jetty in manifests/java.yml (v1.64.0-SNAPSHOT): backed by dd-trace-java#11268 (Vert.x) and dd-trace-java#10988 (Jetty) - Remove AIDM-583 workaround from test_library_logs.py: the UnsupportedOperationException in NettyFileUpload.getHttpDataType() was fixed in dd-trace-java#11268, now merged to prod Jira: APPSEC-61873
Contributor
|
|
🎉 All green!🧪 All tests passed 🔗 Commit SHA: 643c1fe | Docs | Datadog PR Page | Give us feedback! |
dd-trace-java#11268 is merged to main but the CI runs against the released artifact, which still has the UnsupportedOperationException in NettyFileUpload.getHttpDataType(). Restore the allowed_pattern until the fix ships in a release.
claponcet
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Test_Blocking_request_body_filenamesforvertx3,vertx4andspring-boot-jettyweblogs inmanifests/java.yml(versionv1.64.0-SNAPSHOT)tests/test_library_logs.pywith an updated comment clarifying it must be removed once the fix ships in a released tracer version (not just merged to main)Motivation
Follow-up to:
server.request.body.filenamesfor Vert.x 3.4/4.0/5.0 (merged to main)server.request.body.filenamesfor Jetty 8-11 (merged to main)Both tracer PRs are merged, unblocking these weblogs. The manifest entries use
v1.64.0-SNAPSHOTso CI only runs the tests once that version is the active release.Additional Notes
The AIDM-583 workaround (allowing the error log
Failed to handle exception in instrumentation for io.netty.handler.codec.http.multipart.HttpPostMultipartRequestDecoderfor vertx3/vertx4) must stay until the dd-trace-java#11268 fix is in a released tracer version. CI runs against the released artifact, not SNAPSHOT builds, so removing the workaround now would breaktest_java_telemetry_logsfor vertx3/vertx4.Jira ticket: APPSEC-61873
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.