feat(realtime): lucy-2.5 + optional sampleFrameData on set/setImage#135
Draft
tomershlasky wants to merge 10 commits into
Draft
feat(realtime): lucy-2.5 + optional sampleFrameData on set/setImage#135tomershlasky wants to merge 10 commits into
tomershlasky wants to merge 10 commits into
Conversation
commit: |
…o LiveKit signaling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lucy-2.5realtime model (shared/model.ts, exposed viamodels.realtime("lucy-2.5")and the registry).sampleFrameData(Blob | File | base64 string | null) torealtime.set()andrealtime.setImage(), serialized as a newsample_frame_datafield on the existingset_imageWS message. Field is only emitted when the caller passes it — no behavior change for existing callers.lucy-2.5option in the playground (packages/sdk/index.html).Merge with main / LiveKit re-home
Main shipped the LiveKit migration (#122/#138) and observability orchestrator (#132) since this branch last picked up main. The legacy
webrtc-connection.ts/webrtc-manager.tsmodules are gone, so the original wiring was re-homed onto the new transport:signaling-channel.ts#setImagenow writessample_frame_dataon the outgoingset_imageWS frame when provided.stream-session.ts#setImageforwards via the existingImageSetOptionsplumbing.realtime/client.ts#setImageaccepts the publicsampleFrameData(Blob/File/string/null) and converts to base64 at the boundary.realtime/methods.ts#setdoes the same conversion at the helper boundary.ImageSetOptionsinrealtime/types.ts; wire field onSetImageMessage.Test cleanup: dropped the old
WebRTCConnection/WebRTCManager-specific tests that no longer apply; added focusedsampleFrameDatacoverage onmockSession.setImageintests/realtime.unit.test.ts.Test plan
pnpm -F @decartai/sdk buildcleanpnpm -F @decartai/sdk lintandformat:checkcleanpnpm -F @decartai/sdk test— 210/210 pass (5 test files), incl. new sampleFrameData wire coverage/v1/stream: connect withlucy-2.5, toggle reference-frame checkbox, confirmsample_frame_dataappears on the outgoingset_imageWS frame in DevTools (and is absent when the checkbox is off)