test(e2e): isolate sync option-routing children from ambient NODE_OPTIONS - #109
Merged
Conversation
…IONS The runCli helper spread process.env into the spawned CLI, so a shell whose NODE_OPTIONS makes node print a startup warning polluted stderr ahead of the JSON error envelope and broke JSON.parse in the --format json assertion. Reproduced with NODE_OPTIONS='--require <emit-warning script>': 1 failed / 19 passed before, 20/20 after. The child now drops NODE_OPTIONS and sets NODE_NO_WARNINGS, matching cli-cache-degraded's handling. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the environment-dependent failure in
cli-sync-option-routing.e2e.test.ts: therunClihelper spreadprocess.envinto the spawned CLI process, so a shell whoseNODE_OPTIONScauses node to print a startup warning ((node:<pid>) …) polluted stderr ahead of the JSON error envelope, breakingJSON.parsein the--format jsonassertion.Changes Made
runClichild env now dropsNODE_OPTIONSand setsNODE_NO_WARNINGS=1, matchingcli-cache-degraded.e2e.test.ts's existing handling.Test Coverage
Reproduced deterministically with
NODE_OPTIONS='--require <script calling process.emitWarning>': 1 failed / 19 passed before the fix, 20/20 after, and 20/20 in a clean environment. This is the only e2e suite that parses stderr as JSON.Backward Compatibility
✅ Test-only change; no production code touched.
Size: Small ✓
🤖 Generated with Claude Code