fix: add lib64 to link search path for Fedora/RHEL#4
Open
rramphal wants to merge 1 commit into
Open
Conversation
On distros where cmake's GNUInstallDirs defaults CMAKE_INSTALL_LIBDIR to lib64, the vendored opus build succeeds but linking fails because the search path only includes lib/. Adding lib64 as an additional search path fixes this — non-existent -L paths are silently ignored by the linker, so no behavioral change on platforms that use lib/.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Fedora, RHEL, and other distros where cmake's
GNUInstallDirsdefaultsCMAKE_INSTALL_LIBDIRtolib64, the vendored opus build compiles successfully but linking fails:build.rsemitscargo:rustc-link-search=native={dst}/lib, but cmake installslibopus.ato{dst}/lib64/.Fix: Add
lib64as an additional search path. A non-existent-Lpath is silently ignored by the linker, so this has no behavioral change on platforms that already uselib/.Environment: Fedora 42, cmake 3.31, GCC 15, Rust nightly, opus-codec 0.1.2.