Skip to content

Fix watcher stale root cleanup#666

Closed
pcristin wants to merge 2 commits into
DeusData:mainfrom
pcristin:codex/286-stale-root-cleanup
Closed

Fix watcher stale root cleanup#666
pcristin wants to merge 2 commits into
DeusData:mainfrom
pcristin:codex/286-stale-root-cleanup

Conversation

@pcristin

@pcristin pcristin commented Jun 28, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Track consecutive missing project roots in the watcher.
  • Preserve projects through transient missing-root checks, then prune after three consecutive misses.
  • Delete cached project DB/WAL/SHM files when sustained absence is confirmed.
  • Add a regression test covering transient miss preservation and sustained cleanup.

Fixes #286.

Validation

  • make -f Makefile.cbm build/c/test-runner passed.
  • git diff --check passed.

@pcristin pcristin marked this pull request as ready for review June 28, 2026 13:47
@pcristin

Copy link
Copy Markdown
Contributor Author

Damn, got a lucky number unintentionally xD

@DeusData

Copy link
Copy Markdown
Owner

Huge thanks for opening this PR and for the work you put into it.

The maintainer shop is currently full, so this may sit for a bit before it gets a proper review. We will come back to this as soon as possible with real feedback; I wanted to make sure it did not sit unacknowledged in the meantime.

@DeusData DeusData added enhancement New feature or request ux/behavior Display bugs, docs, adoption UX priority/normal Standard review queue; useful PR with ordinary maintainer urgency. labels Jun 29, 2026
@DeusData

DeusData commented Jul 1, 2026

Copy link
Copy Markdown
Owner

Thanks for the watcher cleanup. Please refresh the branch/title so generated/session naming is removed from the PR metadata and merge commit message. The non-merge commits appear DCO-signed, but if CI flags the merge commit, rebasing onto current main should clear it.

pcristin added 2 commits July 1, 2026 15:26
Signed-off-by: pcristin <xxxokzxxx@protonmail.com>
Signed-off-by: pcristin <xxxokzxxx@protonmail.com>
@pcristin pcristin force-pushed the codex/286-stale-root-cleanup branch from 756fc9d to 36b0b87 Compare July 1, 2026 12:26
@pcristin pcristin requested a review from DeusData as a code owner July 1, 2026 12:26
@pcristin pcristin changed the title [codex] fix watcher stale root cleanup Fix watcher stale root cleanup Jul 1, 2026
@pcristin pcristin closed this Jul 1, 2026
@pcristin pcristin deleted the codex/286-stale-root-cleanup branch July 1, 2026 12:27
@pcristin pcristin restored the codex/286-stale-root-cleanup branch July 1, 2026 12:28
@pcristin

pcristin commented Jul 1, 2026

Copy link
Copy Markdown
Contributor Author

@DeusData
By renaming PR branch, this PR was closed. Did all of what you asked and opened a new one: #738
Hope, It's okay

@pcristin pcristin deleted the codex/286-stale-root-cleanup branch July 1, 2026 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request priority/normal Standard review queue; useful PR with ordinary maintainer urgency. ux/behavior Display bugs, docs, adoption UX

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature Request: Automatic deletion of project when underlying folder is deleted

2 participants