Fix watcher stale root cleanup#666
Closed
pcristin wants to merge 2 commits into
Closed
Conversation
Contributor
Author
|
Damn, got a lucky number unintentionally xD |
Owner
|
Huge thanks for opening this PR and for the work you put into it. The maintainer shop is currently full, so this may sit for a bit before it gets a proper review. We will come back to this as soon as possible with real feedback; I wanted to make sure it did not sit unacknowledged in the meantime. |
Owner
|
Thanks for the watcher cleanup. Please refresh the branch/title so generated/session naming is removed from the PR metadata and merge commit message. The non-merge commits appear DCO-signed, but if CI flags the merge commit, rebasing onto current |
Signed-off-by: pcristin <xxxokzxxx@protonmail.com>
Signed-off-by: pcristin <xxxokzxxx@protonmail.com>
756fc9d to
36b0b87
Compare
4 tasks
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #286.
Validation
make -f Makefile.cbm build/c/test-runnerpassed.git diff --checkpassed.