Add mobile loading skeletons and empty states#138
Open
jamunatg2006-sys wants to merge 2 commits into
Open
Conversation
Author
|
Hi , the mobile checks pass locally:
The failing Vercel check appears to be due to deployment authorization, not code changes. Please review when possible. |
Harxhit
added
the
gssoc:approved
Collaborator
|
Please join our Discord community from the README section so we can communicate properly and provide valid labels for your contributions, which will help you score points in GSSoC. |
Author
|
Hi @Harxhit, as of now there are no conflicts in the code. Only the PR approval and merge are pending. Please check it once. |
Collaborator
Your PR is quite large, so please give us some time to properly review all the changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the mobile app loading and empty-state experience by adding reusable skeleton/empty-state patterns across screens that previously used abrupt loading transitions, spinner-only loading, or plain text placeholders.
Closes #119
Changes Made
Verification
corepack pnpm --filter @devcard/mobile exec tsc --noEmitcorepack pnpm --filter @devcard/mobile exec jest --runInBandcorepack pnpm --filter @devcard/mobile lintgit diff --checkScreenshots
Not added, because changes are state-based and verified locally through code checks/tests.