backend: add onRequest request-logging middleware with tests#141
Closed
dangzitou wants to merge 1 commit into
Closed
Conversation
Collaborator
|
@dangzitou Closing this PR because #142 duplicates the work already covered in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The backend has no request-level logging, making it difficult to trace incoming traffic during development and debugging. This PR adds an onRequest Fastify hook in buildApp() that logs each request's method and URL via the built-in pino logger (app.log.info) with a structured object, keeping output consistent with existing pino/pino-pretty formatting. A new Vitest test suite in app.test.ts verifies the hook fires by spying on app.log.info after injecting a synthetic request.
Changes
Validation
Risks