fix: use randomBytes() instead of Math.random() for OAuth state gener…#145
Merged
ShantKhatri merged 1 commit intoMay 18, 2026
Merged
Conversation
Collaborator
|
@ShantKhatri These changes look good to merge. Please review them and provide the final approval. |
ShantKhatri
approved these changes
May 18, 2026
Contributor
|
Hi @MehtabSandhu11 , we appreciate your contribution and also the PR standards you followed. Once again thanks for the contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the
generateState()function inauth.tsandconnect.tsby replacing the insecureMath.random()implementation with a cryptographically secure random value for the OAuthstateparameter.Problem
The previous implementation used:
Math.random()is not cryptographically secure and can produce predictable values. Since the OAuthstateparameter is used to prevent CSRF attacks, predictable state values weaken this protection.Fix
Replaced the implementation with
randomBytes()from Node.js' built-incryptomodule:This generates 256 bits of cryptographically secure randomness, making the OAuth
stateparameter unpredictable and resistant to CSRF attacks.Files Changed
apps/backend/src/routes/auth.tsapps/backend/src/routes/connect.tsRelated
Closes #123