fix: pass JWT via URL fragment instead of query param in mobile redirect#146
Open
MehtabSandhu11 wants to merge 1 commit into
Open
fix: pass JWT via URL fragment instead of query param in mobile redirect#146MehtabSandhu11 wants to merge 1 commit into
MehtabSandhu11 wants to merge 1 commit into
Conversation
Harxhit
added
the
gssoc:approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the mobile OAuth redirect in auth.ts to pass the JWT token via a URL fragment (#) instead of a query parameter (?).
Problem
Both the GitHub and Google OAuth callbacks were redirecting mobile users with the JWT as a plain query parameter:
tsreturn reply.redirect(
${mobileRedirect}?token=${token});This meant the JWT (valid for 30 days) was:
Visible in server access logs
Stored in browser/webview history
Potentially captured by analytics or proxy tools
Exposed to any third-party JavaScript reading location.href
Fix
Changed ? to # so the token is passed as a URL fragment:
tsreturn reply.redirect(
${mobileRedirect}#token=${token});URL fragments are never sent to the server in HTTP requests, so the token won't appear in access logs or be forwarded to proxies.
Files Changed
apps/backend/src/routes/auth.ts
Related
Closes #122