Preserve ZIP modified times when signing packages#20
Merged
Marc-André Moreau (mamoreau-devolutions) merged 1 commit intoMay 31, 2026
Conversation
Portable package signing rewrote ZIP entries with zip::write::FileOptions defaults, which left DOS timestamps at 1980-01-01. That made signed files inside NuGet packages lose their Windows Date modified metadata. Preserve timestamps on copied ZIP entries, stamp rewritten and new entries with local wall-clock time, and cover the behavior with targeted NuGet and ZIP repack tests. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Marc-André Moreau (mamoreau-devolutions)
approved these changes
May 31, 2026
Marc-André Moreau (mamoreau-devolutions)
merged commit a380ade
into
Devolutions:master
18 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation