Fix I04 chain: fastcs 0.14.0-beta.2, yaml-driven launch, symbol-name fixes#55
Merged
Conversation
Refactor CATioServerController.__init__ to accept a CATioServerControllerOptions dataclass (TCP/route/scan-timings sub-dataclasses) so the controller can be driven by the FastCS yaml-launch flow. Bolt fastcs.launch._launch onto the existing typer app so `run` and `schema` subcommands sit alongside the bespoke `ioc` command. Update the example fastcs.yaml + regenerate schema.json + adjust the test_system fixture and the phoebus launcher accordingly. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
- set_id(pv_prefix) → set_path([pv_prefix]) (set_id removed in b2) - fastcs.yaml controllers: dict-keyed-by-id → list with explicit id: - relax test_cli_version: launcher now emits app + FastCS version lines Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Add abbreviations for 'limit' -> 'lim', 'compact' -> 'cpt', and 'map' -> 'm' to prevent truncation from discarding distinguishing suffixes when generating fastcs_names for long symbol names. Also reorder _ABBREVIATIONS alphabetically by abbreviation value for easier maintenance. Add test_terminal_yaml_duplicates.py to detect any future duplicate fastcs_name entries in terminal_types.yaml symbol nodes and CoE subindices.
- Extend trim_ecat_name() to handle names with invalid fastcs characters (e.g., hyphens in 'BL04I-EA-ERIO-01') - Convert non-UpperCamelCase names by splitting on non-alphanumeric runs and title-casing letter-starting segments - Preserve numeric-only segments by appending to last letter segment to avoid collisions (e.g., 'ERIO-01' vs 'ERIO-02') - Add comprehensive tests including hyphenated names and numeric suffix differentiation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #55 +/- ##
==========================================
+ Coverage 73.68% 73.92% +0.23%
==========================================
Files 19 19
Lines 4093 4130 +37
==========================================
+ Hits 3016 3053 +37
Misses 1077 1077 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
set_id→set_path, controllers list with explicitid:, version banner change)CATioServerController.__init__to accept aCATioServerControllerOptionsdataclass so the controller can be driven by the FastCS yaml-launch flow; boltfastcs.launch._launchonto the typer app (run/schemasubcommands alongsideioc)BL04I-EA-ERIO-01) to valid fastcs group names, preserving numeric suffixes to avoid collisionslimit/compact/mapabbreviations and reorder_ABBREVIATIONSto stop truncation from dropping distinguishing suffixes (fixes duplicatefastcs_namein EP4374-0002)test_terminal_yaml_duplicates.pyto guard against future duplicatefastcs_nameentries.planning/scratch directoryTest plan
pytestpasses locally (unit + system tests, including the new duplicate-name guard)catio runandcatio schemawork via the new yaml-launch flowopi/phoebus-launch.sh) still launches correctly with the updated entrypoint🤖 Generated with Claude Code