Update FIB metadata parsing and registration logic#825
Merged
Conversation
…ttern associated with the FIB waffle method
…t available stage position value present in the metadata
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #825 +/- ##
==========================================
+ Coverage 52.90% 52.94% +0.03%
==========================================
Files 99 99
Lines 10760 10773 +13
Branches 1415 1420 +5
==========================================
+ Hits 5693 5704 +11
Misses 4769 4769
- Partials 298 300 +2 🚀 New features to boost your workflow:
|
stephen-riggs
approved these changes
Jun 16, 2026
stephen-riggs
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me. Does this resolve the issue which caused the current FIB dlq messages?
Contributor
Author
This will only partially address it. The 'waffle' method workflow has a very different data structure compared to the full AutoTEM workflow. It will necessitate additional logic (potentially on the FIBContext side) to fully separate the two workflows and how files from each workflow are handled. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, we forcibly mapped certain FIB steps to certain stage value fields. However, as Murfey's FIB workflow is run on more types of FIB datasets, we find that this hard mapping is incorrect in certain cases. Additionally, sites set up and selected outside of AutoTEM having a different naming pattern than if they were configured completely using AutoTEM.
This PR makes the metadata registration more flexible by using the latest available stage position name to perform the ISPyB and Murfey database registrations. It also updates the number extraction function to handle these additional site naming patterns