Skip to content

Update FIB metadata parsing and registration logic#825

Merged
tieneupin merged 2 commits into
mainfrom
update-fib-parsing-logic
Jun 16, 2026
Merged

Update FIB metadata parsing and registration logic#825
tieneupin merged 2 commits into
mainfrom
update-fib-parsing-logic

Conversation

@tieneupin

@tieneupin tieneupin commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Previously, we forcibly mapped certain FIB steps to certain stage value fields. However, as Murfey's FIB workflow is run on more types of FIB datasets, we find that this hard mapping is incorrect in certain cases. Additionally, sites set up and selected outside of AutoTEM having a different naming pattern than if they were configured completely using AutoTEM.

This PR makes the metadata registration more flexible by using the latest available stage position name to perform the ISPyB and Murfey database registrations. It also updates the number extraction function to handle these additional site naming patterns

…t available stage position value present in the metadata
@codecov

codecov Bot commented Jun 16, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 73.13433% with 18 lines in your changes missing coverage. Please review.
✅ Project coverage is 52.94%. Comparing base (95769c0) to head (f33e7e9).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #825      +/-   ##
==========================================
+ Coverage   52.90%   52.94%   +0.03%     
==========================================
  Files          99       99              
  Lines       10760    10773      +13     
  Branches     1415     1420       +5     
==========================================
+ Hits         5693     5704      +11     
  Misses       4769     4769              
- Partials      298      300       +2     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tieneupin tieneupin marked this pull request as ready for review June 16, 2026 09:52
@tieneupin tieneupin self-assigned this Jun 16, 2026
@tieneupin tieneupin added enhancement New feature or request server Relates to the server component fib Part of the FIB pipeline extension labels Jun 16, 2026

@stephen-riggs stephen-riggs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Does this resolve the issue which caused the current FIB dlq messages?

@tieneupin

tieneupin commented Jun 16, 2026

Copy link
Copy Markdown
Contributor Author

Does this resolve the issue which caused the current FIB dlq messages?

This will only partially address it. The 'waffle' method workflow has a very different data structure compared to the full AutoTEM workflow. It will necessitate additional logic (potentially on the FIBContext side) to fully separate the two workflows and how files from each workflow are handled.

@tieneupin tieneupin merged commit ba586ab into main Jun 16, 2026
17 checks passed
@tieneupin tieneupin deleted the update-fib-parsing-logic branch June 16, 2026 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request fib Part of the FIB pipeline extension server Relates to the server component

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants