Add Navigation Tabs widget support to JsonMap#222
Open
OCopping wants to merge 5 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #222 +/- ##
==========================================
- Coverage 94.77% 94.74% -0.04%
==========================================
Files 10 10
Lines 861 894 +33
==========================================
+ Hits 816 847 +31
- Misses 45 47 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
OCopping
requested review from
adedamola-sode,
niamhdougan and
tomkane-dls
and removed request for
adedamola-sode
Including minor changes to conftest.py
OCopping
force-pushed
the
add-navtabs-support-jsonmap
branch
from
3256f70 to
f690e06
Compare
Collaborator
|
Is there a branch of i19-services and/or techui-support that I can test against? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will add support to the JsonMap generation for Navigation Tabs widgets, allowing it to detect and dive in to files on the tabs.