theme 2845 record-list fixes#208
Merged
cairocoder01 merged 3 commits intoJul 14, 2026
Merged
Conversation
✅ Deploy Preview for jade-chebakia-17493f ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
cairocoder01
requested changes
Jul 3, 2026
cairocoder01
left a comment
cairocoder01
left a comment
Collaborator
There was a problem hiding this comment.
See comments inline which my Claude code review pointed out. Instead of its full text, here is its summary:
Bottom line
The bubbling changes are correct and verified working. The placeholder work needs two fixes before merge: (1) input::placeholder → textarea::placeholder in the component CSS, and (2) wire placeholder into the story's render()/argTypes so it's actually demonstrable. Both are Medium — the feature currently ships as effectively inert.
Collaborator
|
Looks good @brady-lamansky-gtt. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@cairocoder01 This is connected to DiscipleTools/disciple-tools-theme#2845
I updated all related components & set bubbles: true to allow simpler 'change' event tracking for all components at once, rather than individual.
Also, I added the 'placeholder' attribute to dt-textarea field
Related theme PR: DiscipleTools/disciple-tools-theme#2927