ENG-2032 Disable sidebar open not respected#1233
Draft
mdroidian wants to merge 1 commit into
Draft
Conversation
- Store setting value in variable for explicit checking - Use strict equality (=== true) instead of truthy evaluation - This ensures the setting is respected in all cases, including when value might be undefined Addresses ENG-2032 Co-authored-by: Michael Gartner <mdroidian@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The "Disable sidebar open" setting was not being respected when creating new discourse nodes. New nodes would still open in the sidebar even when the setting was enabled.
Solution
Made the setting check more robust by:
=== true) instead of truthy evaluationTechnical Details
The issue was in the
handleOpenInSidebarfunction withincreateDiscourseNode.ts. The original check used truthy evaluation which could potentially cause issues if the setting value was undefined or had unexpected values.The fix ensures that the sidebar only opens when the setting is explicitly
falseorundefined(default behavior), and is properly disabled when the setting istrue.Testing
All node creation pathways go through the
createDiscourseNodefunction:All these pathways now properly respect the "Disable sidebar open" setting.
Notes
The fix is defensive and handles edge cases where the setting might not be properly initialized or might have unexpected values.
Linear Issue: ENG-2032