Skip to content

ENG-2039 Create a generic upsert route#1237

Open
maparent wants to merge 3 commits into
mainfrom
eng-2039-create-a-generic-upsert-route
Open

ENG-2039 Create a generic upsert route#1237
maparent wants to merge 3 commits into
mainfrom
eng-2039-create-a-generic-upsert-route

Conversation

@maparent

@maparent maparent commented Jul 18, 2026

Copy link
Copy Markdown
Collaborator

@linear-code

linear-code Bot commented Jul 18, 2026

Copy link
Copy Markdown

ENG-2039

@vercel

vercel Bot commented Jul 18, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
discourse-graph Ready Ready Preview, Comment Jul 19, 2026 1:43pm

Request Review

@supabase

supabase Bot commented Jul 18, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project zytfjzqyijgagqxrzbmz because there are no changes detected in packages/database/supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 2 potential issues.

View 1 additional finding in Devin Review.

Open in Devin Review

Comment thread apps/website/app/api/internal/space/[id]/route.ts
Comment thread packages/database/src/lib/crossAppConverters.ts
@graphite-app

graphite-app Bot commented Jul 19, 2026

Copy link
Copy Markdown
Contributor

PR size/scope check

This PR is over our review-size guideline.

  • Recommended: ~200 lines changed
  • Acceptable limit: up to 400 lines when well-scoped/self-contained
  • Preferred file count: fewer than 5 files

Please split this into smaller PRs unless there is a clear reason the changes need to land together.

If keeping it as one PR, please add a brief justification covering:

  • What single problem this PR solves
  • Why the files/changes are coupled

Comment thread packages/database/features/addGeneric.feature Outdated
@maparent
maparent force-pushed the eng-2039-create-a-generic-upsert-route branch from 201f07c to 42ce851 Compare July 19, 2026 02:02
@maparent
maparent force-pushed the eng-2039-create-a-generic-upsert-route branch from 42ce851 to b368c4c Compare July 19, 2026 13:11
@maparent
maparent force-pushed the eng-2039-create-a-generic-upsert-route branch 2 times, most recently from e557164 to bbe2ba9 Compare July 19, 2026 13:16
Comment thread packages/database/src/lib/crossAppConverters.ts Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant