Skip to content

Make /etc/os-release optional #538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TobiPeterG wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −2
Open

Make /etc/os-release optional #538

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions module/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,14 @@
# more details.
#

include /etc/os-release
ifneq ($(wildcard /etc/os-release),)
-include /etc/os-release
Copy link
Copy Markdown
Contributor

@elguero elguero Apr 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you are doing the check above for the existence of the os-release file, then you don't need the - before the include. I mean, no harm, it is just redundant.

endif

ifneq (,$(findstring rhel,$(ID_LIKE)))
ELFLAG := -DEL$(VERSION_ID)
ifneq (,$(VERSION_ID))
Copy link
Copy Markdown
Contributor

@elguero elguero Apr 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we adding a check for $VERSION_ID? If ID_LIKE is not set because there is no os-release file, then this block would be skipped anyways.

ELFLAG := -DEL$(VERSION_ID)
endif
endif

Raspbian := $(shell grep -Eic 'raspb(erry|ian)' /proc/cpuinfo /etc/os-release 2>/dev/null )
Expand Down