Skip to content

Change url to path at homework & Improve legibility#130

Open
academey wants to merge 2 commits into
DjangoGirls:masterfrom
academey:fix-ko-homework-readme
Open

Change url to path at homework & Improve legibility#130
academey wants to merge 2 commits into
DjangoGirls:masterfrom
academey:fix-ko-homework-readme

Conversation

@academey

@academey academey commented Aug 30, 2019

Copy link
Copy Markdown

Hello,

I changed code like below at your ko/homework/README.md

*url(r'^drafts/$', views.post_draft_list, name='post_draft_list'), *
to
path('drafts/', views.post_draft_list, name='post_draft_list'),

And also improved legibility.

Thanks.

@academey academey changed the title Fix homework typing error & Improve legibility Change url to path at homework & Improve legibility Aug 30, 2019
@das-g

das-g commented Aug 30, 2019

Copy link
Copy Markdown
Member

👍 We should think about using the more explicit <int:pk> instead of just <pk> in the code in the English version, too.

@das-g

das-g commented Aug 30, 2019

Copy link
Copy Markdown
Member

As I don't understand corean, I've only reviewed the code change itself. Can someone from @DjangoGirls/ko-pr check whether they happen in the right context?

@academey

Copy link
Copy Markdown
Author

It doesn't be reviewed for a long time
I just changed orders so it will be okay for right context. Thanks.
@das-g

@das-g

das-g commented Sep 24, 2020

Copy link
Copy Markdown
Member

Can someone from @DjangoGirls/ko-pr please hava a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants