Skip to content

fix(dojoos-api-consumer): repair the broken local OpenAPI spec paths (DOJ-6634) - #7

Open
lapc506 wants to merge 1 commit into
mainfrom
chore/fix-broken-openapi-local-paths
Open

fix(dojoos-api-consumer): repair the broken local OpenAPI spec paths (DOJ-6634)#7
lapc506 wants to merge 1 commit into
mainfrom
chore/fix-broken-openapi-local-paths

Conversation

@lapc506

@lapc506 lapc506 commented Aug 8, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Two absolute local paths in agents/dojoos-api-consumer.md still named dojo-documentation, a directory that no longer exists on disk.
  • This one is genuinely broken, unlike its two sibling PRs in the same rename sweep. Those reference the repo by name and are covered by GitHub's rename redirect; a filesystem has no redirect.

Linear Issue

DOJ-6634

Measured

/home/…/dojocoding/dojo-documentation/public/openapi.yaml   BROKEN
/home/…/dojocoding/dojocoding-docs/public/openapi.yaml      EXISTS (64901 bytes)

The local checkout was renamed along with the repository, so the old directory is simply gone.

Why nobody reported it

Line 99 is step 1 of the spec-resolution order and is guarded with "if the file exists". Step 2 immediately after it is a live WebFetch of https://docs.dojocoding.io/openapi.yaml.

So the agent degrades gracefully: step 1 silently never fires, step 2 succeeds, and everything appears to work. A silent fallback that never fires is indistinguishable from one that works — which is exactly how this survived the rename with no error, no log line, and no ticket.

What is actually lost, and the reason to fix it rather than shrug:

  • Every session pays a network round trip that the local mirror existed to avoid.
  • The offline / rate-limited path is gone. If docs.dojocoding.io is unreachable the agent now falls through to step 3, STATUS: ERROR — OpenAPI spec unreachable, where the mirror would previously have carried it.

The change

-1. **Local fallback**: `Read` `…/dojocoding/dojo-documentation/public/openapi.yaml` if the file exists.
+1. **Local fallback**: `Read` `…/dojocoding/dojocoding-docs/public/openapi.yaml` if the file exists.

-- **Local mirror (dev)**: `…/dojocoding/dojo-documentation/public/openapi.yaml`
+- **Local mirror (dev)**: `…/dojocoding/dojocoding-docs/public/openapi.yaml`

Scope — why only two lines

Six other dojo-documentation mentions remain in this repo and are deliberately untouched: CHANGELOG.md ×2, README.md, skills/stage-tracker/SKILL.md, skills/startup-intake/SKILL.md, and agents/dojoos-api-consumer.md:365 ("the dojo-documentation platform"). All are prose or repo-relative references, not absolute filesystem paths, so none of them is broken. They belong to the separate cosmetic pass.

Verified after the change: git grep -c dojo-documentation returns exactly those 6.

Base branch

Targets main, this repository's default. Checked rather than assumed — this repo has no develop.

Reviewer note on provenance

This change was initially briefed to me as "do not touch these — the local directory still has the old name, so updating them would break them today." Re-measuring showed the opposite, and the brief's author confirmed it after checking.

The brief was true when it was written and expired before it was acted on: the directory did exist under the old name earlier that day and was renamed afterwards. Worth recording because a measurement with no timestamp reads as current forever — that, rather than the two-line diff, is the transferable part.

Created by Claude Code on behalf of @lapc506

…(DOJ-6634)

Two absolute local paths still named `dojo-documentation`, which no longer
exists on disk — the local checkout was renamed with the repo. Unlike the other
two repos in this sweep, these are filesystem paths, and a filesystem has no
rename redirect. They are broken now, not stale:

  /home/…/dojocoding/dojo-documentation/public/openapi.yaml   BROKEN
  /home/…/dojocoding/dojocoding-docs/public/openapi.yaml      EXISTS (64901 bytes)

Nobody reported it because line 99 is guarded with "if the file exists" and the
next step is a live WebFetch of docs.dojocoding.io. The agent degrades
gracefully: step 1 silently never fires, step 2 succeeds, everything looks
fine. A silent fallback that never fires is indistinguishable from one that
works, which is exactly how this survived the rename.

What was actually lost is the reason to fix it: every session pays a network
round trip the local mirror existed to avoid, and the offline path is gone — if
docs.dojocoding.io is unreachable the agent now falls through to
`STATUS: ERROR — OpenAPI spec unreachable`, where the mirror would have carried
it.

Two lines. The six remaining `dojo-documentation` mentions in this repo are
prose or repo-relative rather than absolute paths, including line 365's "the
dojo-documentation platform", and are left for the separate cosmetic pass.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

@dojo-code-reviewer dojo-code-reviewer Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved

Approved — 0 blockers, 1 P3. Confidence: 4.80/5.00.

Walkthrough

⚠️ GOVERNANCE WARNING: This PR targets the main branch directly. Per standard GitFlow, PRs should target develop before merging to main. Since this repository has no develop branch and default-targets main, this warning is advisory and does not block approval.

Walkthrough

This PR corrects the absolute local fallback paths for the OpenAPI spec in the dojoos-api-consumer agent definition to match the newly renamed dojocoding-docs repository name.

Reviewed Files

  • agents/dojoos-api-consumer.md

Safety Rationale

The change is completely safe because the absolute path is checked conditionally ("if the file exists") and seamlessly falls back to a live network fetch of the spec if the local mirror is not found.

Approved — 0 blockers, 1 P3.

🔵 P3 — Minor

  • agents/dojoos-api-consumer.md:100 — 🔵 P3 (minor) — The absolute local fallback path is specific to a single developer's machine structure (/home/kvttvrsis/...). If other team members run or develop this plugin locally, the absolute path lookup will fail for them, meaning they won't benefit from local offline mirroring. This forces them to fall back to live network fetches each time, which is slower and won't work in offline scenarios. We could add a sibling relative path fallback check (e.g., ../dojocoding-docs/public/openapi.yaml or checks relative to ~) to make the setup portable across development environments.

[pass 1]


Total findings: 1 business context (1 total)


1. **Local fallback**: `Read` `/home/kvttvrsis/Documentos/GitHub/dojocoding/dojo-documentation/public/openapi.yaml` if the file exists.
1. **Local fallback**: `Read` `/home/kvttvrsis/Documentos/GitHub/dojocoding/dojocoding-docs/public/openapi.yaml` if the file exists.
2. **Live fetch**: `WebFetch` `https://docs.dojocoding.io/openapi.yaml` with the prompt `"Return the full raw YAML content verbatim, no summarization"`.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 P3 (minor) — The absolute local fallback path is specific to a single developer's machine structure (/home/kvttvrsis/...). If other team members run or develop this plugin locally, the absolute path lookup will fail for them, meaning they won't benefit from local offline mirroring. This forces them to fall back to live network fetches each time, which is slower and won't work in offline scenarios. We could add a sibling relative path fallback check (e.g., ../dojocoding-docs/public/openapi.yaml or checks relative to ~) to make the setup portable across development environments.

[pass 1]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants