remove unused constraints#81
Open
koenbeuk wants to merge 1 commit into
Open
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes unintended where TEntity : class constraints from EF Core expressive extension stubs so that delegate-based expressive overloads can bind to value-type projections (e.g., after Select(o => o.Price)), aligning the stubs’ generic constraints with EF Core’s actual queryable extension method constraints.
Changes:
- Removed incorrect reference-type (
class) constraints from several EF Core async stub overloads (e.g.,SumAsync,AverageAsync,FirstAsync,MinAsync,MaxAsync) and fromTagWith/TagWithCallSite. - Added integration tests exercising async methods over value-type projections (including a “modern syntax” switch expression).
- Added a reflection-based test to detect “over-constrained” stubs where Expressive stubs have a
classconstraint but EF Core targets do not.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/ExpressiveSharp.EntityFrameworkCore.IntegrationTests/Tests/StubSignatureTests.cs | Adds a reflection-based guard test to catch overly restrictive class constraints on expressive EF Core stubs. |
| tests/ExpressiveSharp.EntityFrameworkCore.IntegrationTests/Infrastructure/AsyncQueryableTestBase.cs | Adds integration tests proving async methods work over value-type projections and with modern syntax inside the selector/predicate. |
| src/ExpressiveSharp.EntityFrameworkCore/Extensions/ExpressiveQueryableEfCoreExtensions.cs | Removes incorrect where TEntity : class constraints so stubs bind correctly for value-type element queries. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before: expressive overloads would only bind to reference types. that was a bad copy/paste. Now it binds properly to value types as well