feat: named ring/field instances for ring/field structure selection#1067
Merged
Conversation
A carrier type can carry several ring/field structures; the tactics silently used the first registered one with no way to disambiguate. Give instances an optional name at declaration (`instance ring [foo] with T ...`) and let the tactic target it (`ring [foo]` / `field [foo]`). Bare `ring`/`field` are unchanged: with no name, the first matching instance is used, so the single-structure case behaves identically.
bgregoir
reviewed
Jul 7, 2026
bgregoir
left a comment
bgregoir
left a comment
Contributor
There was a problem hiding this comment.
This will be pretty cool.
bgregoir
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A carrier type can carry several ring/field structures; the tactics
silently used the first registered one with no way to disambiguate.
Give instances an optional name at declaration:
and let the tactic target it:
Bare
ring/fieldare unchanged: with no name, the first matchinginstance is used, so the single-structure case behaves identically.