Skip to content

fix(clone): proof * [tag] must not drop untagged axioms #1098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
namasikanam wants to merge 1 commit into
base: main
Choose a base branch
from
+21 −9
Open

fix(clone): proof * [tag] must not drop untagged axioms #1098

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 7 additions & 9 deletions src/ecTheoryReplay.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,15 +351,13 @@ let check_evtags ?(tags : evtags option) (src : symbol list) =
let dfl =
not (List.mem explicit src) &&
not (List.exists (fun (mode, _) -> mode = `Include) tags) in
let stt =
List.map (fun src ->
let do1 status (mode, dst) =
match mode with
| `Exclude -> if sym_equal src dst then raise Reject; status
| `Include -> status || (sym_equal src dst)
in List.fold_left do1 dfl tags)
src
in List.mem true stt
let has_tag dst = List.exists (fun s -> sym_equal s dst) src in
let do1 status (mode, dst) =
match mode with
| `Exclude -> if has_tag dst then raise Reject; status
| `Include -> status || has_tag dst
in
List.fold_left do1 dfl tags

with Reject -> false

Expand Down
14 changes: 14 additions & 0 deletions tests/clone-proofstar-tagdrop.ec
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
(* Regression for the clone `proof * [tag]` untagged-axiom drop.

Under a bracketed prove-all directive (`proof * [-dummy]`) the UNTAGGED
FinType.enum_spec axiom must still be FORCED. With `enum <- [0]` it is
false, so the discharging `by smt()` cannot prove it and the whole `clone`
command must fail. Before the fix the untagged axiom was silently dropped,
so this clone was accepted (and `F.enum_spec` could be used to prove
`false`). *)
require import AllCore List FinType.

fail clone FinType as F with
type t <- int,
op enum <- [0]
proof * [-dummy] by smt().
Loading